Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/cldsrv 350 veeam routes ensure concurrency updates #5056

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Bugfix/cldsrv 350 veeam routes ensure concurrency updates #5056

merged 3 commits into from
Mar 21, 2023

Conversation

williamlardier
Copy link
Contributor

@williamlardier williamlardier commented Mar 15, 2023 •
edited
Loading

Arsenal PR: scality/Arsenal#2098

This PR ensures concurreny writes won'rt cause data loss in the bucket metadata when two files are uploaded at the same time for veeam. See ZENKO-4526.

@bert-e
Copy link
Contributor

bert-e commented Mar 15, 2023

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 15, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-350 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.7.9

Please check the Fix Version/s of CLDSRV-350, or the target
branch of this pull request.

@williamlardier williamlardier mentioned this pull request Mar 15, 2023
Merged
@williamlardier williamlardier force-pushed the bugfix/CLDSRV-350-veeam-routes-ensure-concurrency-updates branch 4 times, most recently from 6f51323 to de79626 Compare March 16, 2023 08:28
@williamlardier williamlardier force-pushed the bugfix/CLDSRV-350-veeam-routes-ensure-concurrency-updates branch from de79626 to 743d123 Compare March 16, 2023 13:28
@williamlardier williamlardier force-pushed the bugfix/CLDSRV-350-veeam-routes-ensure-concurrency-updates branch from 743d123 to 89cac8a Compare March 21, 2023 12:49
@bert-e
Copy link
Contributor

bert-e commented Mar 21, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-350 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.7.10

Please check the Fix Version/s of CLDSRV-350, or the target
branch of this pull request.

@williamlardier
CLDSRV-350: bump arsenal version
1bab851
@williamlardier
CLDSRV-350: update veeam put and delete routes with new arsenal methods
11e3d7e 
We must ensure that concurrent updates of the bucket metadata won't conflict
with each other, by separately updating the capabilities fields. This change
ensures that two files can be uploaded at the same without any problem,
regardless of the number of cloudserver instances.
@williamlardier
CLDSRV-350: bump to 8.7.10
58fc0b7
@williamlardier williamlardier force-pushed the bugfix/CLDSRV-350-veeam-routes-ensure-concurrency-updates branch from 359c93c to 58fc0b7 Compare March 21, 2023 12:52
@williamlardier
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e Mar 21, 2023
@bert-e
Copy link
Contributor

bert-e commented Mar 21, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.7

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.4
  • development/8.5
  • development/8.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 21, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.4
  • development/8.5
  • development/8.6

Please check the status of the associated issue CLDSRV-350.

Goodbye williamlardier.

@bert-e bert-e merged commit 58fc0b7 into development/8.7 Mar 21, 2023
@bert-e bert-e deleted the bugfix/CLDSRV-350-veeam-routes-ensure-concurrency-updates branch March 21, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazToozs KazToozs KazToozs approved these changes

@Kerkesni Kerkesni Kerkesni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@williamlardier @bert-e @KazToozs @Kerkesni