Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDSRV-362 - Throw error when copying a cold or transitioning object #5075

Merged
merged 5 commits into from
Mar 28, 2023
Merged

CLDSRV-362 - Throw error when copying a cold or transitioning object #5075

merged 5 commits into from
Mar 28, 2023

Conversation

Kerkesni
Copy link
Contributor

A cold object should not be allowed to get copied as the data is not accessible.

Same issue happens when copying an object that is transitioning, the data might get deleted while copying is still in progress.

Issue: CLDSRV-362

@bert-e
Copy link
Contributor

bert-e commented Mar 21, 2023

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@scality scality deleted a comment from bert-e Mar 21, 2023
@bert-e
Copy link
Contributor

bert-e commented Mar 21, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@Kerkesni Kerkesni force-pushed the bugfix/CLDSRV-362-fail-copy-of-cold-object branch from ea995c4 to 742b719 Compare March 21, 2023 17:25
@bert-e
Copy link
Contributor

bert-e commented Mar 21, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-362 contains:

  • 8.7.10

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.7.11

Please check the Fix Version/s of CLDSRV-362, or the target
branch of this pull request.

@Kerkesni Kerkesni force-pushed the bugfix/CLDSRV-362-fail-copy-of-cold-object branch from 742b719 to 34c3fbb Compare March 22, 2023 10:40
@Kerkesni Kerkesni force-pushed the bugfix/CLDSRV-362-fail-copy-of-cold-object branch from 34c3fbb to bd5216a Compare March 22, 2023 11:02
@Kerkesni Kerkesni force-pushed the bugfix/CLDSRV-362-fail-copy-of-cold-object branch from bd5216a to e74b9ea Compare March 22, 2023 12:03
@Kerkesni Kerkesni force-pushed the bugfix/CLDSRV-362-fail-copy-of-cold-object branch from e74b9ea to 16018dd Compare March 22, 2023 15:15
@Kerkesni Kerkesni force-pushed the bugfix/CLDSRV-362-fail-copy-of-cold-object branch from 16018dd to 0d308b9 Compare March 22, 2023 15:39
francoisferrand
francoisferrand approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@francoisferrand francoisferrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

KazToozs
KazToozs reviewed Mar 28, 2023
View reviewed changes
Copy link

@KazToozs KazToozs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Kerkesni added 2 commits March 28, 2023 12:24
@Kerkesni
add helper to check if object is in cold storage
e592671 
Issue: CLDSRV-362
@Kerkesni
throw error when copying a cold or transitioning object
b5334ba 
A cold object should not be allowed to get copied as the data
is not accessible.

Same issue happens when copying an object that is transitioning,
the data might get deleted while copying is still in progress.

Issue: CLDSRV-362
Kerkesni added 3 commits March 28, 2023 12:24
@Kerkesni
throw error when copying parts from a cold object
49841c5 
A cold object should not be allowed to get copied as the data
is not accessible.

Issue: CLDSRV-362
@Kerkesni
throw error when getting a transitioning object
310f67d 
Issue: CLDSRV-362
@Kerkesni
bump version to 8.7.11
6c22d87 
Issue: CLDSRV-362
@Kerkesni Kerkesni force-pushed the bugfix/CLDSRV-362-fail-copy-of-cold-object branch from 0d308b9 to 6c22d87 Compare March 28, 2023 10:25
@Kerkesni
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e Mar 28, 2023
@bert-e
Copy link
Contributor

bert-e commented Mar 28, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.7

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.4
  • development/8.5
  • development/8.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 28, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.4
  • development/8.5
  • development/8.6

Please check the status of the associated issue CLDSRV-362.

Goodbye kerkesni.

@bert-e bert-e merged commit 6c22d87 into development/8.7 Mar 28, 2023
@bert-e bert-e deleted the bugfix/CLDSRV-362-fail-copy-of-cold-object branch March 28, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisferrand francoisferrand francoisferrand approved these changes

@KazToozs KazToozs KazToozs approved these changes

@KillianG KillianG KillianG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kerkesni @bert-e @francoisferrand @KazToozs @KillianG