Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that delete markers are not listed for version suspended buckets #5168

Conversation

KillianG
Copy link
Contributor

@KillianG KillianG commented May 22, 2023

Issue: CLDSRV-347

@bert-e
Copy link
Contributor

bert-e commented May 22, 2023

Hello killiang,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 22, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-347 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.7.21

Please check the Fix Version/s of CLDSRV-347, or the target
branch of this pull request.

@KillianG KillianG force-pushed the bugfix/CLDSRV-347/fix-listing-of-versioning-suspended-bucket-delete-markers branch from 1ebe503 to 8cfe4be Compare May 23, 2023 13:49
@KillianG KillianG marked this pull request as ready for review May 23, 2023 13:59
@KillianG KillianG closed this May 23, 2023
@KillianG KillianG reopened this May 23, 2023
@KillianG KillianG force-pushed the bugfix/CLDSRV-347/fix-listing-of-versioning-suspended-bucket-delete-markers branch from d7a5e14 to 9bfc0f5 Compare May 24, 2023 14:00
@KillianG KillianG changed the title Bump Arsenal Test that delete markers are not listed for version suspended buckets May 24, 2023
@bert-e
Copy link
Contributor

bert-e commented May 24, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@KillianG KillianG force-pushed the bugfix/CLDSRV-347/fix-listing-of-versioning-suspended-bucket-delete-markers branch 4 times, most recently from daee9dc to dfd40ed Compare May 25, 2023 12:38
@KillianG KillianG force-pushed the bugfix/CLDSRV-347/fix-listing-of-versioning-suspended-bucket-delete-markers branch 3 times, most recently from 78b431a to 2e47e9f Compare May 25, 2023 13:56
@KillianG KillianG requested a review from francoisferrand May 26, 2023 08:31
@KillianG KillianG force-pushed the bugfix/CLDSRV-347/fix-listing-of-versioning-suspended-bucket-delete-markers branch from b285a46 to fd662a8 Compare May 26, 2023 08:46
@scality scality deleted a comment from bert-e May 26, 2023
@bert-e
Copy link
Contributor

bert-e commented May 26, 2023

Conflict

There is a conflict between your branch bugfix/CLDSRV-347/fix-listing-of-versioning-suspended-bucket-delete-markers and the
destination branch development/8.7.

Please resolve the conflict on the feature branch (bugfix/CLDSRV-347/fix-listing-of-versioning-suspended-bucket-delete-markers).

git fetch && \
git checkout origin/bugfix/CLDSRV-347/fix-listing-of-versioning-suspended-bucket-delete-markers && \
git merge origin/development/8.7

Resolve merge conflicts and commit

git push origin HEAD:bugfix/CLDSRV-347/fix-listing-of-versioning-suspended-bucket-delete-markers

@bert-e
Copy link
Contributor

bert-e commented May 26, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@KillianG
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented May 30, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.7

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5
  • development/8.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 30, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5
  • development/8.6

Please check the status of the associated issue CLDSRV-347.

Goodbye killiang.

@bert-e bert-e merged commit 32401c9 into development/8.7 May 30, 2023
@bert-e bert-e deleted the bugfix/CLDSRV-347/fix-listing-of-versioning-suspended-bucket-delete-markers branch May 30, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants