-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow updating restored object expiration delay #5174
Conversation
If the object is already restored, we simply need to update the expiry date, as per AWS docs: > After restoring an archived object, you can update the restoration > period by reissuing the request with a new period. Amazon S3 updates > the restoration period relative to the current time. Issue: CLDSRV-393
This should never have been commited, as it disables most unit tests from CI. This caused some tests to actually fail: * bad import of refactored `objectDelete` api * getting an object while transitioning (archiving) is allowed Issue: CLDSRV-393
Lint will fail if it finds any `describe.only` or `it.only`. Issue: CLDSRV-393
Hello francoisferrand,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
afd7c8d
to
ea28450
Compare
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
/bypass_author_approval |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: bypass_author_approval |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-393. Goodbye francoisferrand. |
As per AWS docs, if the object is already restored, the s3:restore api may be used update the expiry
date:
The code did mostly that, but rejected the call as it checked the storage class (which is back to
'hot' when the object is restored), and did not update the expiry date of the object.
Issue: CLDSRV-393