Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updating restored object expiration delay #5174

Merged
merged 6 commits into from
May 25, 2023

Conversation

francoisferrand
Copy link
Contributor

@francoisferrand francoisferrand commented May 24, 2023

As per AWS docs, if the object is already restored, the s3:restore api may be used update the expiry
date:

After restoring an archived object, you can update the restoration
period by reissuing the request with a new period. Amazon S3 updates
the restoration period relative to the current time.

The code did mostly that, but rejected the call as it checked the storage class (which is back to
'hot' when the object is restored), and did not update the expiry date of the object.

  • Update expiry date on s3:restore on restored object
  • Remove describe.only
  • Add eslint rule to prevent exclusive tests
  • Bump github actions

Issue: CLDSRV-393

If the object is already restored, we simply need to update the expiry
date, as per AWS docs:
> After restoring an archived object, you can update the restoration
> period by reissuing the request with a new period. Amazon S3 updates
> the restoration period relative to the current time.

Issue: CLDSRV-393
This should never have been commited, as it disables most unit tests from
CI.

This caused some tests to actually fail:
* bad import of refactored `objectDelete` api
* getting an object while transitioning (archiving) is allowed

Issue: CLDSRV-393
Lint will fail if it finds any `describe.only` or `it.only`.

Issue: CLDSRV-393
@bert-e
Copy link
Contributor

bert-e commented May 24, 2023

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@francoisferrand francoisferrand changed the title Allow updating restored object expiriation delay Allow updating restored object expiration delay May 24, 2023
@scality scality deleted a comment from bert-e May 24, 2023
@bert-e
Copy link
Contributor

bert-e commented May 24, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@bert-e
Copy link
Contributor

bert-e commented May 25, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-393 contains:

  • 8.7.21

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.7.22

Please check the Fix Version/s of CLDSRV-393, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented May 25, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@rahulreddy
Copy link
Collaborator

/bypass_author_approval

@bert-e
Copy link
Contributor

bert-e commented May 25, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.7

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5
  • development/8.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: bypass_author_approval

@bert-e
Copy link
Contributor

bert-e commented May 25, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5
  • development/8.6

Please check the status of the associated issue CLDSRV-393.

Goodbye francoisferrand.

@bert-e bert-e merged commit 5d54dd5 into development/8.7 May 25, 2023
@bert-e bert-e deleted the bugfix/CLDSRV-393 branch May 25, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants