Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDSRV-498 Handling isNull master version with no versionId #5526

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

nicolas2bert
Copy link
Contributor

In certain cases, a master version may not have a versionId and be set as null (isNull:true). For instance, this occurs when a customer:

  • Create a bucket.
  • Put an object to it.
  • Put bucket versioning.
  • Put metadata (BackbeatClient.putMetadata), which results in the master version being set to null (isNull:true) with no versionId.

Currently, if an object is put after these steps, CloudServer fails to appropriately generate a null version. This is because CloudServer doesn't handle situations where the master version is set to isNull:true with no versionId.

The correct approach when an object is put should be to:

  • Create the new version key.
  • Create a new null version key, assigning it a “default non-version version id”.
  • Update this “default non-version version id” to the nullVersionId field of the master key.

@nicolas2bert nicolas2bert force-pushed the bugfix/CLDSRV-497/putmetadata branch 3 times, most recently from 6a37bf3 to c52a3a6 Compare February 15, 2024 16:31
Base automatically changed from bugfix/CLDSRV-497/putmetadata to development/7.10 February 15, 2024 19:00
@bert-e
Copy link
Contributor

bert-e commented Feb 15, 2024

Hello nicolas2bert,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 15, 2024

Incorrect fix version

The Fix Version/s in issue CLDSRV-498 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.45

  • 7.70.44

  • 8.6.25

  • 8.7.45

  • 8.8.18

Please check the Fix Version/s of CLDSRV-498, or the target
branch of this pull request.

@nicolas2bert nicolas2bert force-pushed the bugfix/CLDSRV-498/null branch 2 times, most recently from 9a6234f to c42deab Compare February 16, 2024 09:42
@bert-e
Copy link
Contributor

bert-e commented Feb 16, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

In certain cases, a master version may not have a versionId and be set as null (isNull:true). For instance, this occurs when a customer:

Create a bucket.

Put an object to it.

Put bucket versioning.

Put metadata (BackbeatClient.putMetadata), which results in the master version being set to null (isNull:true) with no versionId.

Currently, if an object is put after these steps, CloudServer fails to appropriately generate a null version. This is because CloudServer doesn't handle situations where the master version is set to isNull:true with no versionId.

The correct approach when an object is put should be to:

Create the new version key.

Create a new null version key, assigning it a “default non-version version id”.

Update this “default non-version version id” to the `nullVersionId` field of the master key.
@nicolas2bert nicolas2bert force-pushed the bugfix/CLDSRV-498/null branch from c42deab to 632ef26 Compare February 20, 2024 11:05
@bert-e
Copy link
Contributor

bert-e commented Feb 20, 2024

Incorrect fix version

The Fix Version/s in issue CLDSRV-498 contains:

  • 7.10.45

  • 7.70.45

  • 8.6.26

  • 8.7.46

  • 8.8.19

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.46

  • 7.70.45

  • 8.6.26

  • 8.7.46

  • 8.8.19

Please check the Fix Version/s of CLDSRV-498, or the target
branch of this pull request.

@nicolas2bert
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented Feb 20, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@nicolas2bert
Copy link
Contributor Author

/create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Feb 20, 2024

Conflict

A conflict has been raised during the creation of
integration branch w/7.70/bugfix/CLDSRV-498/null with contents from bugfix/CLDSRV-498/null
and development/7.70.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/7.70/bugfix/CLDSRV-498/null origin/development/7.70
 $ git merge origin/bugfix/CLDSRV-498/null
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/7.70/bugfix/CLDSRV-498/null

The following options are set: create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Feb 20, 2024

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Feb 20, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

Copy link
Contributor

@benzekrimaha benzekrimaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolas2bert
Copy link
Contributor Author

@bert-e approve

@bert-e
Copy link
Contributor

bert-e commented Feb 21, 2024

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/7.10

  • ✔️ development/7.70

  • ✔️ development/8.6

  • ✔️ development/8.7

  • ✔️ development/8.8

The following branches will NOT be impacted:

  • development/7.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Feb 21, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.10

  • ✔️ development/7.70

  • ✔️ development/8.6

  • ✔️ development/8.7

  • ✔️ development/8.8

The following branches have NOT changed:

  • development/7.4

Please check the status of the associated issue CLDSRV-498.

Goodbye nicolas2bert.

@bert-e bert-e merged commit 632ef26 into development/7.10 Feb 21, 2024
18 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-498/null branch February 21, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants