Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDSRV-547 [HOTFIX 9.3.0.5] cherry-pick #5606

Merged
merged 2 commits into from
Jun 27, 2024
Merged

CLDSRV-547 [HOTFIX 9.3.0.5] cherry-pick #5606

merged 2 commits into from
Jun 27, 2024

Conversation

jonathan-gramain
Copy link
Contributor

No description provided.

@jonathan-gramain
bf: CLDSRV-547 update redis config for utapi reindex
6084921 
Update the redis configuration of utapi reindex to include a list of
sentinels, rather than a single sentinel (previously set to
"localhost" in Federation).

I took this opportunity to cleanup tech debt related to parsing redis
configuration, using "joi" for validation instead and making it common
across the three different places where redis config is parsed. Not
doing so would have required yet another copy-paste of dumb and
error-prone validation code. Added unit tests for the new validation.

(cherry picked from commit be49e55)
@jonathan-gramain
CLDSRV-547 [hotfix 7.70] bump version to 7.70.45-3
3f8dcf9
@bert-e
Copy link
Contributor

bert-e commented Jun 27, 2024

Hello jonathan-gramain,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jun 27, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@jonathan-gramain
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jun 27, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jun 27, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ hotfix/7.70.45

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6
  • development/8.7
  • development/8.8

Please check the status of the associated issue CLDSRV-547.

Goodbye jonathan-gramain.

The following options are set: approve

@bert-e bert-e merged commit 3f8dcf9 into hotfix/7.70.45 Jun 27, 2024
11 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-547-hotfix-7.70.45 branch June 27, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmacro tmacro tmacro approved these changes

@BourgoisMickael BourgoisMickael BourgoisMickael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathan-gramain @bert-e @tmacro @BourgoisMickael