-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converge cloudserver images #5716
Conversation
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## development/9.0 #5716 +/- ##
================================================
Coverage 62.11% 62.11%
================================================
Files 185 185
Lines 11624 11624
================================================
Hits 7220 7220
Misses 4404 4404
Flags with carried forward coverage won't be shown. Click here to find out more. |
6f7f399
to
1114fa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to post to the #eng-federation chan for review.
/approve |
Benefit is to avoid duplicating image, make sure we actually run the build we tested, and reduce dependency on federation. Additionally, switched to `ochinchina/supervisord`, so we can fully remove the python dependency and reduce image size. Differences are very few: - Run as `scality` user - Run supervisord as entrypoint Issue: CLDSRV-597
Remove redundant shell command (implicit from using shell form of `CMD`) and use exec to run supervisord. Issue: CLDSRV-597
1114fa3
to
36c92c0
Compare
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-597. Goodbye francoisferrand. The following options are set: approve |
Build federation image as additional layers on top of "standard" cloudserver image, to avoid duplication and ensure the image we tested is used in production.
There are still some differences at the moment (e.g. name of user, path) which should be further converged to minimize differences, may be done over time after considering all things.
This allows us to fully control (and minimize) what gets into the image, relying on any official node image. Also, now switch from python-based supervisord to a golang reimplementation [1], to minimize dependencies and CVEs.
Finally, took the change to fix startup command of the image, to ensure it properly propagates OS signals.
[1] ochinchina/supervisord
Issue: CLDSRV-597