Upgrade to NodeJS 22

.github/actions/setup-ci/action.yaml

@@ -18,7 +18,7 @@ runs:
         mkdir -p /tmp/artifacts/${JOB_NAME}/;
     - uses: actions/setup-node@v4
       with:
-        node-version: '16'
+        node-version: '22'
         cache: 'yarn'
     - name: install typescript
       shell: bash

.github/workflows/tests.yaml

@@ -71,13 +71,13 @@ env:
   GIT_CLONE_PROTECTION_ACTIVE: 'false'
 jobs:
   lint:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
     - name: Checkout
       uses: actions/checkout@v4
     - uses: actions/setup-node@v4
       with:
-        node-version: '16'
+        node-version: '22'
         cache: yarn
     - name: install typescript
       shell: bash
@@ -100,13 +100,13 @@ jobs:
       run: yamllint -c yamllint.yml $(git ls-files "*.yml")
 
   unit-tests:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
     - name: Checkout
       uses: actions/checkout@v4
     - uses: actions/setup-node@v4
       with:
-        node-version: '16'
+        node-version: '22'
         cache: yarn
     - name: install typescript
       shell: bash
@@ -120,6 +120,7 @@ jobs:
         yarn run cover test_legacy_location
       env:
         S3_LOCATION_FILE: tests/locationConfig/locationConfigTests.json
+        NO_PROXY: "test.scality.com,scality.com"
     - name: Upload test results to Codecov
       uses: codecov/test-results-action@v1
       with:
@@ -149,7 +150,7 @@ jobs:
       if: always()
 
   build:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     permissions:
       contents: read
       packages: write
@@ -220,7 +221,7 @@ jobs:
           cache-to: type=gha,mode=max,scope=mongodb
 
   multiple-backend:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     needs: build
     env:
       CLOUDSERVER_IMAGE: ghcr.io/${{ github.repository }}:${{ github.sha }}
@@ -262,7 +263,7 @@ jobs:
       if: always()
 
   mongo-v0-ft-tests:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     needs: build
     env:
       S3BACKEND: mem
@@ -300,7 +301,7 @@ jobs:
       if: always()
 
   mongo-v1-ft-tests:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     needs: build
     env:
       S3BACKEND: mem
@@ -345,7 +346,7 @@ jobs:
         include:
           - job-name: file-ft-tests
     name: ${{ matrix.job-name }}
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     needs: build
     env:
       S3BACKEND: file
@@ -383,8 +384,9 @@ jobs:
       if: always()
 
   utapi-v2-tests:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     needs: build
+    if: false
     env:
       ENABLE_UTAPI_V2: t
       S3BACKEND: mem
@@ -416,7 +418,7 @@ jobs:
       if: always()
 
   quota-tests:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     needs: build
     strategy:
       matrix:
@@ -460,7 +462,7 @@ jobs:
       if: always()
 
   kmip-ft-tests:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     needs: build
     env:
       S3BACKEND: file
@@ -498,7 +500,7 @@ jobs:
       if: always()
 
   ceph-backend-test:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     needs: build
     env:
       S3BACKEND: mem

Dockerfile

@@ -1,4 +1,4 @@
-ARG NODE_VERSION=16.20.2-bookworm-slim
+ARG NODE_VERSION=22.14.0-bookworm-slim
 
 FROM node:${NODE_VERSION} AS builder
 
@@ -22,8 +22,11 @@ RUN apt-get update \
     && ssh-keyscan -H github.com > /root/ssh/known_hosts
 
 ENV PYTHON=python3
+RUN npm install -g \
+    node-gyp \
+    typescript@4.9.5
 COPY package.json yarn.lock /usr/src/app/
-RUN npm install typescript@4.9.5 -g
+
 RUN yarn install --production --ignore-optional --frozen-lockfile --ignore-engines --network-concurrency 1
 
 ################################################################################

README.md

@@ -5,6 +5,11 @@
 [![Docker Pulls][badgedocker]](https://hub.docker.com/r/zenko/cloudserver)
 [![Docker Pulls][badgetwitter]](https://twitter.com/zenko)
 
+## Build Status
+
+![Public Build Status][badgepub]
+![Private Build Status][badgepriv]
+
 ## Overview
 
 CloudServer (formerly S3 Server) is an open-source Amazon S3-compatible

bin/create_bucket_with_NFS_enabled.js

@@ -1,4 +1,4 @@
 #!/usr/bin/env node
-'use strict'; // eslint-disable-line strict
+'use strict';
 
 require('../lib/nfs/utilities.js').createBucketWithNFSEnabled();

bin/create_encrypted_bucket.js

@@ -1,5 +1,5 @@
 #!/bin/sh
 // 2>/dev/null ; exec "$(which nodejs || which node)" "$0" "$@"
-'use strict'; // eslint-disable-line strict
+'use strict';
 
 require('../lib/kms/utilities.js').createEncryptedBucket();

bin/list_bucket_metrics.js

@@ -1,4 +1,4 @@
 #!/usr/bin/env node
-'use strict'; // eslint-disable-line strict
+'use strict';
 
 require('../lib/utapi/utilities.js').listMetrics('buckets');

bin/list_metrics.js

@@ -1,4 +1,4 @@
 #!/usr/bin/env node
-'use strict'; // eslint-disable-line strict
+'use strict';
 
 require('../lib/utapi/utilities.js').listMetrics();

bin/metrics_server.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-'use strict'; // eslint-disable-line strict
+'use strict';
 
 const {
     startWSManagementClient,

bin/search_bucket.js

@@ -1,6 +1,6 @@
 #!/bin/sh
 // 2>/dev/null ; exec "$(which nodejs 2>/dev/null || which node)" "$0" "$@"
-'use strict'; // eslint-disable-line strict
+'use strict';
 
 const { auth } = require('arsenal');
 const commander = require('commander');

bin/secure_channel_proxy.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-'use strict'; // eslint-disable-line strict
+'use strict';
 
 const {
     startWSManagementClient,

config.json

@@ -67,27 +67,27 @@
         "allowFrom": ["127.0.0.1/8", "::1"]
     },
     "metadataClient": {
-        "host": "localhost",
+        "host": "127.0.0.1",
         "port": 9990
     },
     "dataClient": {
-        "host": "localhost",
+        "host": "127.0.0.1",
         "port": 9991
     },
     "pfsClient": {
-        "host": "localhost",
+        "host": "127.0.0.1",
         "port": 9992
     },
     "metadataDaemon": {
-        "bindAddress": "localhost",
+        "bindAddress": "127.0.0.1",
         "port": 9990
     },
     "dataDaemon": {
-        "bindAddress": "localhost",
+        "bindAddress": "127.0.0.1",
         "port": 9991
     },
     "pfsDaemon": {
-        "bindAddress": "localhost",
+        "bindAddress": "127.0.0.1",
         "port": 9992
     },
     "recordLog": {

dataserver.js

@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line strict
+'use strict';
 
 const arsenal = require('arsenal');
 const { config } = require('./lib/Config.js');

.eslintrc → eslint.config.mjs

@@ -1,12 +1,28 @@
-{
-    "extends": "scality",
-    "plugins": [
-        "mocha"
-    ],
-    "env": {
-        "es2020": true
+import mocha from "eslint-plugin-mocha";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default [...compat.extends('@scality/scality'), {
+    plugins: {
+        mocha,
     },
-    "rules": {
+
+    languageOptions: {
+        ecmaVersion: 2020,
+        sourceType: "script",
+    },
+
+    rules: {
         "import/extensions": "off",
         "lines-around-directive": "off",
         "no-underscore-dangle": "off",
@@ -50,8 +66,6 @@
         "no-multi-spaces": "off",
         "quote-props": "off",
         "mocha/no-exclusive-tests": "error",
+        "no-redeclare": ["error", { "builtinGlobals": false }],
     },
-    "parserOptions": {
-        "ecmaVersion": 2020
-    }
-}
+}];

index.js

@@ -1,4 +1,4 @@
-'use strict'; // eslint-disable-line strict
+'use strict';
 
 require('werelogs').stderrUtils.catchAndTimestampStderr(
     undefined,

lib/Config.js

@@ -20,7 +20,11 @@ const {
     allowedUtapiEventFilterStates,
     supportedLifecycleRules,
 } = require('../constants');
-const { utapiVersion } = require('utapi');
+
+// TODO CLDSRV-610: re-enable utapi
+// const { utapiVersion } = require('utapi');
+const utapiVersion = null;
+
 const { scaleMsPerDay } = s3middleware.objectUtils;
 
 const constants = require('../constants');

lib/api/api.js

@@ -83,11 +83,9 @@ auth.setHandler(vault);
 const api = {
     callApiMethod(apiMethod, request, response, log, callback) {
         // Attach the apiMethod method to the request, so it can used by monitoring in the server
-        // eslint-disable-next-line no-param-reassign
         request.apiMethod = apiMethod;
         // Array of end of API callbacks, used to perform some logic
         // at the end of an API.
-        // eslint-disable-next-line no-param-reassign
         request.finalizerHooks = [];
 
         const actionLog = monitoringMap[apiMethod];
@@ -150,7 +148,6 @@ const api = {
         // Extract all the _apiMethods and store them in an array
         const apiMethods = requestContexts ? requestContexts.map(context => context._apiMethod) : [];
         // Attach the names to the current request
-        // eslint-disable-next-line no-param-reassign
         request.apiMethods = apiMethods;
 
         function checkAuthResults(authResults) {

lib/api/apiUtils/authorization/permissionChecks.js

@@ -529,10 +529,10 @@ function checkIp(value) {
         try {
             try {
                 parseCIDR(values[i]);
-            } catch (err) {
+            } catch {
                 isValid(values[i]);
             }
-        } catch (err) {
+        } catch {
             return errString;
         }
 
@@ -576,7 +576,6 @@ function validatePolicyConditions(policy) {
         if (s.Condition) {
             const conditionOperators = Object.keys(s.Condition);
             // there can be multiple condition operations in the Condition enclosure
-            // eslint-disable-next-line no-restricted-syntax
             for (const conditionOperator of conditionOperators) {
                 const conditionKey = Object.keys(s.Condition[conditionOperator])[0];
                 const conditionValue = s.Condition[conditionOperator][conditionKey];

lib/api/apiUtils/authorization/prepareRequestContexts.js

@@ -155,13 +155,6 @@ function prepareRequestContexts(apiMethod, request, sourceBucket,
                 generateRequestContext('objectPutTaggingVersion');
             requestContexts.push(putObjectVersionRequestContext);
         }
-    } else if (apiMethodAfterVersionCheck === 'objectPutCopyPart') {
-        const putObjectRequestContext =
-            generateRequestContext('objectPut');
-        requestContexts.push(putObjectRequestContext);
-        const getObjectRequestContext =
-            generateRequestContext('objectGet');
-        requestContexts.push(getObjectRequestContext);
     } else if (apiMethodAfterVersionCheck === 'objectPut') {
         // if put object with version
         if (request.headers['x-scal-s3-version-id'] ||

lib/api/apiUtils/authorization/tagConditionKeys.js

@@ -61,7 +61,6 @@ function updateRequestContextsWithTags(request, requestContexts, apiMethod, log,
             return cb(err);
         }
         // FIXME introduced by CLDSRV-256, this syntax should be allowed by the linter
-        // eslint-disable-next-line no-restricted-syntax
         for (const rc of requestContexts) {
             rc.setNeedTagEval(true);
             if (requestTagsQuery) {

lib/api/apiUtils/bucket/parseWhere.js

@@ -53,7 +53,6 @@ function parseWhere(root) {
         const e1 = parseWhere(root[operator][0]);
         const e2 = parseWhere(root[operator][1]);
 
-        // eslint-disable-next-line
         return { '$and' : [
             e1,
             e2,
@@ -62,7 +61,6 @@ function parseWhere(root) {
         const e1 = parseWhere(root[operator][0]);
         const e2 = parseWhere(root[operator][1]);
 
-        // eslint-disable-next-line
         return  { '$or' : [
             e1,
             e2,