Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZENKO 2776 createBucket Tests #40

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

romainlancia
Copy link
Contributor

[+] test BucketCreate component
[+] test createBucket action

@bert-e
Copy link
Contributor

bert-e commented Oct 6, 2020

Hello lebroz,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 6, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include a mandatory approval from @nicolas2bert.

Copy link
Contributor

@nicolas2bert nicolas2bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First iteration.

src/react/actions/__tests__/s3bucket.test.jsx Outdated Show resolved Hide resolved
src/react/actions/__tests__/utils/testUtil.js Outdated Show resolved Hide resolved
@bert-e
Copy link
Contributor

bert-e commented Oct 6, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include a mandatory approval from @nicolas2bert.

The following reviewers are expecting changes from the author, or must review again:

@romainlancia romainlancia force-pushed the improvement/ZENKO-2776-createBucket-tests branch 4 times, most recently from 5f93aed to 2eb5c85 Compare October 7, 2020 16:41
[+] test BucketCreate component
[+] test createBucket action
[+] add new wrapper reduxMountAct
[+] using reduxMountAct in AccountCreate and BucketCreate
@romainlancia romainlancia force-pushed the improvement/ZENKO-2776-createBucket-tests branch from 2eb5c85 to e2bc2b9 Compare October 7, 2020 16:43
@bert-e
Copy link
Contributor

bert-e commented Oct 7, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include a mandatory approval from @nicolas2bert.

Copy link

@terrydervaux terrydervaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@romainlancia
Copy link
Contributor Author

@bert-e approve

@bert-e
Copy link
Contributor

bert-e commented Oct 7, 2020

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 7, 2020

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.0

Please check the status of the associated issue ZENKO-2776.

Goodbye lebroz.

@bert-e bert-e merged commit 6ccdb70 into development/1.0 Oct 7, 2020
@bert-e bert-e deleted the improvement/ZENKO-2776-createBucket-tests branch October 7, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants