-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZKUI-258 Remove deprecated colors and icons #460
ZKUI-258 Remove deprecated colors and icons #460
Conversation
Hello ghivert,My role is to assist you with the merge of this Status report is not available. |
Boop |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
e91819a
to
720e1d7
Compare
Codecov Report
@@ Coverage Diff @@
## development/1.6 #460 +/- ##
===================================================
- Coverage 51.94% 51.88% -0.07%
===================================================
Files 199 199
Lines 9179 9153 -26
Branches 2473 2462 -11
===================================================
- Hits 4768 4749 -19
+ Misses 4396 4390 -6
+ Partials 15 14 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use the IconHelp and CopyButton directly from core-ui with the latest release.
Other than this LGTM !
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
cb3ff2b
to
bec957a
Compare
Boop |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ZKUI-258. Goodbye ghivert. |
No description provided.