Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZKUI-259: Add Outscale as a custom S3 Location #462

Merged
merged 1 commit into from
Sep 20, 2022
Merged

ZKUI-259: Add Outscale as a custom S3 Location #462

merged 1 commit into from
Sep 20, 2022

Conversation

ChengYanJin
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Sep 19, 2022

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Sep 19, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin ChengYanJin force-pushed the feature/ZKUI-259-Add-outscale-as-cloud-provider-in-storage-location-list branch 2 times, most recently from fffebe1 to a89bc35 Compare September 19, 2022 16:07
@ChengYanJin ChengYanJin force-pushed the feature/ZKUI-259-Add-outscale-as-cloud-provider-in-storage-location-list branch from a89bc35 to 8d53167 Compare September 19, 2022 16:10
JBWatenbergScality
JBWatenbergScality approved these changes Sep 19, 2022
View reviewed changes
src/types/config.ts Outdated
export const ORANGE_S3_ENDPOINT = 'https://cloud.orange-business.com';
export const ORANGE_S3_LOCATION_KEY = 'location-orange-ring-s3-v1';

export const OUTSCALE_PUBLIC_S3_ENDPOINT = 'oos.eu-west-2.outscale.com';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const OUTSCALE_PUBLIC_S3_ENDPOINT = 'oos.eu-west-2.outscale.com';
export const OUTSCALE_PUBLIC_S3_ENDPOINT = 'https://oos.eu-west-2.outscale.com';

src/types/config.ts Outdated
export const OUTSCALE_PUBLIC_S3_LOCATION_KEY =
'location-3ds-outscale-oos-public';

export const OUTSCALE_SNC_S3_ENDPOINT = 'oos.cloudgouv-eu-west-1.outscale.com';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const OUTSCALE_SNC_S3_ENDPOINT = 'oos.cloudgouv-eu-west-1.outscale.com';
export const OUTSCALE_SNC_S3_ENDPOINT = 'https://oos.cloudgouv-eu-west-1.outscale.com';

@ChengYanJin
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Sep 20, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.6

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Sep 20, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.6

The following branches have NOT changed:

  • development/1.4
  • development/1.5

Please check the status of the associated issue ZKUI-259.

Goodbye chengyanjin.

@bert-e bert-e merged commit 0a36a26 into development/1.6 Sep 20, 2022
@bert-e bert-e deleted the feature/ZKUI-259-Add-outscale-as-cloud-provider-in-storage-location-list branch September 20, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBWatenbergScality JBWatenbergScality JBWatenbergScality approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChengYanJin @bert-e @JBWatenbergScality