Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZKUI-270: release 1.5.4 #477

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

ChengYanJin
Copy link
Contributor

No description provided.

@ChengYanJin ChengYanJin marked this pull request as ready for review October 5, 2022 15:29
@codecov-commenter
Copy link

Codecov Report

Merging #477 (9c8f2f5) into development/1.5 (f299894) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           development/1.5     #477   +/-   ##
================================================
  Coverage            51.70%   51.70%           
================================================
  Files                  199      199           
  Lines                 9099     9099           
  Branches              2444     2444           
================================================
  Hits                  4705     4705           
  Misses                4379     4379           
  Partials                15       15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ChengYanJin
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Oct 5, 2022

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 5, 2022

Incorrect fix version

The Fix Version/s in issue ZKUI-270 contains:

  • 1.5.4

  • 1.6.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.5.4

  • 1.6.1

Please check the Fix Version/s of ZKUI-270, or the target
branch of this pull request.

The following options are set: approve

@JBWatenbergScality
Copy link
Contributor

/status

@bert-e
Copy link
Contributor

bert-e commented Oct 5, 2022

Status

Status report is not available.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 5, 2022

Conflict

A conflict has been raised during the creation of
integration branch w/1.6/feature/ZKUI-270-rsl-1.5.4 with contents from feature/ZKUI-270-rsl-1.5.4
and development/1.6.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/1.6/feature/ZKUI-270-rsl-1.5.4 origin/development/1.6
 $ git merge origin/feature/ZKUI-270-rsl-1.5.4
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/1.6/feature/ZKUI-270-rsl-1.5.4

The following options are set: approve

@JBWatenbergScality
Copy link
Contributor

/status

@bert-e
Copy link
Contributor

bert-e commented Oct 5, 2022

Status

Status report is not available.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 5, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.5

  • ✔️ development/1.6

The following branches will NOT be impacted:

  • development/1.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 5, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.5

  • ✔️ development/1.6

The following branches have NOT changed:

  • development/1.4

Please check the status of the associated issue ZKUI-270.

Goodbye chengyanjin.

@bert-e bert-e merged commit 9c8f2f5 into development/1.5 Oct 5, 2022
@bert-e bert-e deleted the feature/ZKUI-270-rsl-1.5.4 branch October 5, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants