Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZKUI 269 Fix account list user and policies regression #478

Conversation

ghivert
Copy link
Contributor

@ghivert ghivert commented Oct 6, 2022

Fix the display bugs on Account User and Policies.

This removes the unneeded margins, and now use a proper stack with gap to space children.

@bert-e
Copy link
Contributor

bert-e commented Oct 6, 2022

Hello ghivert,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 6, 2022

Incorrect fix version

The Fix Version/s in issue ZKUI-269 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.6.1

Please check the Fix Version/s of ZKUI-269, or the target
branch of this pull request.

@codecov-commenter
Copy link

Codecov Report

Merging #478 (57e36ee) into development/1.6 (6788ec8) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

@@                 Coverage Diff                 @@
##           development/1.6     #478      +/-   ##
===================================================
- Coverage            51.97%   51.95%   -0.02%     
===================================================
  Files                  199      199              
  Lines                 9149     9148       -1     
  Branches              2463     2462       -1     
===================================================
- Hits                  4755     4753       -2     
- Misses                4380     4381       +1     
  Partials                14       14              
Impacted Files Coverage Δ
src/react/account/AccountUserList.tsx 76.00% <0.00%> (-0.24%) ⬇️
src/react/account/AccountPoliciesList.tsx 88.77% <50.00%> (-1.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bert-e
Copy link
Contributor

bert-e commented Oct 6, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

Copy link
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ghivert,
image

Figma design:
image

I discovered three small discrepancy compare to our Figma design:

  1. the color of the question mark icon
  2. the color of the + icon
  3. the height of the Edit button is not the same with others.

Thanks!

Copy link
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghivert
Copy link
Contributor Author

ghivert commented Oct 10, 2022

/approve

@bert-e
Copy link
Contributor

bert-e commented Oct 10, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.6

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 10, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.6

The following branches have NOT changed:

  • development/1.4
  • development/1.5

Please check the status of the associated issue ZKUI-269.

Goodbye ghivert.

@bert-e bert-e merged commit 15d81e5 into development/1.6 Oct 10, 2022
@bert-e bert-e deleted the bugfix/ZKUI-269/fix-account-list-user-and-policies-regression branch October 10, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants