-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZKUI 269 Fix account list user and policies regression #478
ZKUI 269 Fix account list user and policies regression #478
Conversation
Hello ghivert,My role is to assist you with the merge of this Status report is not available. |
Codecov Report
@@ Coverage Diff @@
## development/1.6 #478 +/- ##
===================================================
- Coverage 51.97% 51.95% -0.02%
===================================================
Files 199 199
Lines 9149 9148 -1
Branches 2463 2462 -1
===================================================
- Hits 4755 4753 -2
- Misses 4380 4381 +1
Partials 14 14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ghivert,
I discovered three small discrepancy compare to our Figma design:
- the color of the question mark icon
- the color of the + icon
- the height of the Edit button is not the same with others.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ZKUI-269. Goodbye ghivert. |
Fix the display bugs on Account User and Policies.
This removes the unneeded margins, and now use a proper stack with gap to space children.