Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/zk UI 279 fix form #493

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Bugfix/zk UI 279 fix form #493

merged 3 commits into from
Oct 20, 2022

Conversation

MonPote
Copy link
Contributor

@MonPote MonPote commented Oct 20, 2022

No description provided.

This fix is a bit tricky, the bug is really hard to reproduce.
It happen every 10-15 refresh, the form is invalid and stays invalid
for no reason.
I change the mode to onChange so it will try to revalidate each time
the user change the value.
@bert-e
Copy link
Contributor

bert-e commented Oct 20, 2022

Hello monpote,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 20, 2022

Incorrect fix version

The Fix Version/s in issue ZKUI-279 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.6.1

Please check the Fix Version/s of ZKUI-279, or the target
branch of this pull request.

@MonPote MonPote marked this pull request as ready for review October 20, 2022 16:27
@MonPote
Copy link
Contributor Author

MonPote commented Oct 20, 2022

ping

@bert-e
Copy link
Contributor

bert-e commented Oct 20, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@codecov-commenter
Copy link

Codecov Report

Merging #493 (bce314f) into development/1.6 (4918bbc) will increase coverage by 0.02%.
The diff coverage is 48.64%.

@@                 Coverage Diff                 @@
##           development/1.6     #493      +/-   ##
===================================================
+ Coverage            51.17%   51.20%   +0.02%     
===================================================
  Files                  196      196              
  Lines                 9113     9118       +5     
  Branches              2477     2482       +5     
===================================================
+ Hits                  4664     4669       +5     
  Misses                4433     4433              
  Partials                16       16              
Impacted Files Coverage Δ
src/react/IAMProvider.tsx 33.33% <0.00%> (-9.53%) ⬇️
src/react/account/AccountCreateUser.tsx 6.12% <0.00%> (ø)
src/react/account/AccountEditCommonLayout.tsx 90.00% <ø> (ø)
src/react/account/AccountUpdateUser.tsx 5.66% <0.00%> (ø)
src/react/account/AccountUserAccessKeys.tsx 9.75% <ø> (ø)
src/react/account/AccountUserList.tsx 75.75% <0.00%> (ø)
src/react/account/AccountUserSecretKeyModal.tsx 7.40% <ø> (ø)
src/react/account/CreateAccountPolicy.tsx 50.00% <0.00%> (ø)
...ount/iamAttachment/AttachmentConfirmationModal.tsx 77.00% <30.00%> (ø)
src/react/account/UpdateAccountPolicy.tsx 63.63% <33.33%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MonPote
Copy link
Contributor Author

MonPote commented Oct 20, 2022

/approve

@bert-e
Copy link
Contributor

bert-e commented Oct 20, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.6

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 20, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.6

The following branches have NOT changed:

  • development/1.4
  • development/1.5

Please check the status of the associated issue ZKUI-279.

Goodbye monpote.

@bert-e bert-e merged commit bce314f into development/1.6 Oct 20, 2022
@bert-e bert-e deleted the bugfix/ZKUI-279-fix-form branch October 20, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants