Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZKUI-284 - Fix account conflict to access account page #497

Conversation

MonPote
Copy link
Contributor

@MonPote MonPote commented Oct 28, 2022

The test will be implemented on a different PR : ZKUI-285

@bert-e
Copy link
Contributor

bert-e commented Oct 28, 2022

Hello monpote,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 28, 2022

Incorrect fix version

The Fix Version/s in issue ZKUI-284 contains:

  • 1.5.6

  • 1.6.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.5.7

  • 1.6.2

Please check the Fix Version/s of ZKUI-284, or the target
branch of this pull request.

@MonPote MonPote marked this pull request as ready for review October 28, 2022 14:25
@bert-e
Copy link
Contributor

bert-e commented Oct 28, 2022

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Oct 28, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@codecov-commenter
Copy link

Codecov Report

Merging #497 (6fc0377) into development/1.5 (4043dc5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           development/1.5     #497   +/-   ##
================================================
  Coverage            51.70%   51.71%           
================================================
  Files                  199      199           
  Lines                 9099     9100    +1     
  Branches              2444     2444           
================================================
+ Hits                  4705     4706    +1     
  Misses                4379     4379           
  Partials                15       15           
Impacted Files Coverage Δ
src/react/utils/hooks.ts 86.29% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MonPote
Copy link
Contributor Author

MonPote commented Oct 28, 2022

/approve

@bert-e
Copy link
Contributor

bert-e commented Oct 28, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.5

  • ✔️ development/1.6

The following branches will NOT be impacted:

  • development/1.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 28, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.5

  • ✔️ development/1.6

The following branches have NOT changed:

  • development/1.4

Please check the status of the associated issue ZKUI-284.

Goodbye monpote.

@bert-e bert-e merged commit 6fc0377 into development/1.5 Oct 28, 2022
@bert-e bert-e deleted the bugfix/ZKUI-284-fix-account-conflict-to-access-account-page branch October 28, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants