Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved validation of number fields #511

Merged

Conversation

ognyan-kostadinov
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Nov 9, 2022

Hello ognyan-kostadinov,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 9, 2022

Incorrect fix version

The Fix Version/s in issue ZKUI-260 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.6.4

Please check the Fix Version/s of ZKUI-260, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Nov 9, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #511 (f73e28e) into development/1.6 (837236f) will decrease coverage by 0.32%.
The diff coverage is 50.00%.

@@                 Coverage Diff                 @@
##           development/1.6     #511      +/-   ##
===================================================
- Coverage            51.10%   50.77%   -0.33%     
===================================================
  Files                  197      192       -5     
  Lines                 9162     9115      -47     
  Branches              2503     2508       +5     
===================================================
- Hits                  4682     4628      -54     
- Misses                4464     4471       +7     
  Partials                16       16              
Impacted Files Coverage Δ
src/react/Routes.tsx 2.70% <0.00%> (-0.48%) ⬇️
src/react/ZenkoUI.tsx 0.00% <ø> (ø)
src/react/account/AccountContent.tsx 0.00% <0.00%> (ø)
src/react/account/AccountList.tsx 84.37% <ø> (ø)
src/react/account/AccountUserAccessKeys.tsx 7.59% <0.00%> (-2.17%) ⬇️
...backend/location/LocationDetails/storageOptions.ts 100.00% <ø> (ø)
src/react/databrowser/DataBrowser.tsx 0.00% <ø> (ø)
src/react/databrowser/HeaderButtons.tsx 0.00% <ø> (ø)
src/react/databrowser/buckets/BucketDetails.tsx 90.00% <ø> (ø)
src/react/databrowser/buckets/BucketList.tsx 72.50% <ø> (ø)
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ognyan-kostadinov ognyan-kostadinov force-pushed the feature/ZKUI-260/improve-validation-of-number-fields branch from f73e28e to 1dc1e67 Compare November 28, 2022 11:56
@bert-e
Copy link
Contributor

bert-e commented Nov 28, 2022

Incorrect fix version

The Fix Version/s in issue ZKUI-260 contains:

  • 1.6.4

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.6.6

Please check the Fix Version/s of ZKUI-260, or the target
branch of this pull request.

@ognyan-kostadinov
Copy link
Contributor Author

/status

@bert-e
Copy link
Contributor

bert-e commented Nov 28, 2022

Status

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 28, 2022

Incorrect fix version

The Fix Version/s in issue ZKUI-260 contains:

  • 1.6.4

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.6.6

Please check the Fix Version/s of ZKUI-260, or the target
branch of this pull request.

@ognyan-kostadinov
Copy link
Contributor Author

/status

@bert-e
Copy link
Contributor

bert-e commented Nov 28, 2022

Status

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 28, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

Copy link
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ognyan-kostadinov
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Dec 5, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.6

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Dec 5, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.6

The following branches have NOT changed:

  • development/1.4
  • development/1.5

Please check the status of the associated issue ZKUI-260.

Goodbye ognyan-kostadinov.

@bert-e bert-e merged commit 1dc1e67 into development/1.6 Dec 5, 2022
@bert-e bert-e deleted the feature/ZKUI-260/improve-validation-of-number-fields branch December 5, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants