Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZKUI-300 - dirty navbar css fix #531

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

MonPote
Copy link
Contributor

@MonPote MonPote commented Jan 12, 2023

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Jan 12, 2023

Hello monpote,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jan 12, 2023

Incorrect fix version

The Fix Version/s in issue ZKUI-300 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.6.8

Please check the Fix Version/s of ZKUI-300, or the target
branch of this pull request.

@codecov-commenter
Copy link

Codecov Report

Merging #531 (ae967c9) into development/1.6 (683c5f5) will decrease coverage by 0.41%.
The diff coverage is 0.00%.

@@                 Coverage Diff                 @@
##           development/1.6     #531      +/-   ##
===================================================
- Coverage            51.02%   50.60%   -0.42%     
===================================================
  Files                  192      192              
  Lines                 9190     9189       -1     
  Branches              2544     2542       -2     
===================================================
- Hits                  4689     4650      -39     
- Misses                4484     4522      +38     
  Partials                17       17              
Impacted Files Coverage Δ
src/react/Navbar.tsx 0.00% <ø> (ø)
src/react/backend/location/LocationOptions.tsx 15.38% <0.00%> (+1.09%) ⬆️
src/react/ui-elements/Container.ts 83.33% <ø> (ø)
src/react/reducers/uiAccounts.ts 53.84% <0.00%> (-15.39%) ⬇️
src/react/actions/account.ts 30.76% <0.00%> (-11.54%) ⬇️
src/react/actions/configuration.ts 90.00% <0.00%> (-10.00%) ⬇️
src/js/managementClient/api.ts 4.32% <0.00%> (-1.32%) ⬇️
src/react/account/AccountPoliciesList.tsx 88.77% <0.00%> (-1.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MonPote MonPote marked this pull request as ready for review January 13, 2023 15:44
@MonPote
Copy link
Contributor Author

MonPote commented Jan 13, 2023

/approve

@bert-e
Copy link
Contributor

bert-e commented Jan 13, 2023

Incorrect fix version

The Fix Version/s in issue ZKUI-300 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.6.8

Please check the Fix Version/s of ZKUI-300, or the target
branch of this pull request.

The following options are set: approve

@MonPote
Copy link
Contributor Author

MonPote commented Jan 13, 2023

ping

@bert-e
Copy link
Contributor

bert-e commented Jan 13, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.6

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 13, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.6

The following branches have NOT changed:

  • development/1.4
  • development/1.5

Please check the status of the associated issue ZKUI-300.

Goodbye monpote.

@bert-e bert-e merged commit ae967c9 into development/1.6 Jan 13, 2023
@bert-e bert-e deleted the improvement/ZKUI-300-dirty-navbar-fix branch January 13, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants