[ZKUI-349] ✨ Implement GHAS

[gaspardmoindrot]

No description provided.

[bert-e]

Hello gaspardmoindrot,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue ZKUI-349 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 1.6.14

• 2.0.4

Please check the Fix Version/s of ZKUI-349, or the target
branch of this pull request.

[codecov-commenter]

Codecov Report

Merging #586 (5324cfe) into development/1.6 (97277c3) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           development/1.6     #586      +/-   ##
===================================================
- Coverage            55.39%   55.16%   -0.24%     
===================================================
  Files                  218      218              
  Lines                10352    10352              
  Branches              2907     2907              
===================================================
- Hits                  5735     5711      -24     
- Misses                4599     4623      +24     
  Partials                18       18              

see 6 files with indirect coverage changes

[tcarmet]

as this repo is not using any kind of internally made reuasable workflow, feel free to use the one on scality/workflows.

[gaspardmoindrot]

Is it better now ?

[JBWatenbergScality]

Hello, Thanks for your contribution, few comments on my side.

[JBWatenbergScality]

Instead of rebuilding the image, we can run the scan on the image matching the head of the branch.

[tcarmet]

We might be facing a race condition in this case. If we want this workflow to be independent we should be building this image.

[gaspardmoindrot]

You mean using the build that is created in build-push-tests.yml, right? In this case, indeed, we may have a race condition issue since we cannot use cross-file needs.

[JBWatenbergScality]

Hello, Thanks for your contribution, few comments on my side.

[bert-e]

Incorrect fix version

The Fix Version/s in issue ZKUI-349 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 1.6.14

• 2.0.5

Please check the Fix Version/s of ZKUI-349, or the target
branch of this pull request.

[bert-e]

Incorrect fix version

The Fix Version/s in issue ZKUI-349 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 1.6.15

• 2.0.5

Please check the Fix Version/s of ZKUI-349, or the target
branch of this pull request.

[gaspardmoindrot]

ping

[bert-e]

Incorrect fix version

The Fix Version/s in issue ZKUI-349 contains:

• 1.6.14

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 1.6.15

• 2.0.5

Please check the Fix Version/s of ZKUI-349, or the target
branch of this pull request.

[gaspardmoindrot]

ping

[bert-e]

Integration data created

I have created the integration data for the additional destination branches.

• this pull request will merge improvement/ZKUI-349-implement-ghas into
  development/1.6
• w/2.0/improvement/ZKUI-349-implement-ghas will be merged into development/2.0

The following branches will NOT be impacted:

• development/1.4
• development/1.5

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• one peer

Peer approvals must include at least 1 approval from the following list:

• @ChengYanJin

• @MonPote

• @JBWatenbergScality