Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZKUI-359 - fix storage consumption #598

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

MonPote
Copy link
Contributor

@MonPote MonPote commented Jun 5, 2023

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Jun 5, 2023

Hello monpote,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jun 5, 2023

Incorrect fix version

The Fix Version/s in issue ZKUI-359 contains:

  • 2.0.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.6.16

  • 2.0.9

Please check the Fix Version/s of ZKUI-359, or the target
branch of this pull request.

Copy link
Contributor

@JBWatenbergScality JBWatenbergScality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MonPote
Copy link
Contributor Author

MonPote commented Jun 5, 2023

ping

@MonPote
Copy link
Contributor Author

MonPote commented Jun 5, 2023

/approve

@bert-e
Copy link
Contributor

bert-e commented Jun 5, 2023

Incorrect fix version

The Fix Version/s in issue ZKUI-359 contains:

  • 2.0.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.6.16

  • 2.0.9

Please check the Fix Version/s of ZKUI-359, or the target
branch of this pull request.

The following options are set: approve

@JBWatenbergScality
Copy link
Contributor

/status

@bert-e
Copy link
Contributor

bert-e commented Jun 5, 2023

Status

Status report is not available.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jun 5, 2023

Integration data created

I have created the integration data for the additional destination branches.

  • this pull request will merge bugfix/ZKUI-359 into
    development/1.6
  • w/2.0/bugfix/ZKUI-359 will be merged into development/2.0

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@codecov-commenter
Copy link

Codecov Report

Merging #598 (e13cb7a) into development/1.6 (c614413) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           development/1.6     #598      +/-   ##
===================================================
- Coverage            53.80%   53.63%   -0.17%     
===================================================
  Files                  217      217              
  Lines                10377    10380       +3     
  Branches              2892     2893       +1     
===================================================
- Hits                  5583     5567      -16     
- Misses                4775     4794      +19     
  Partials                19       19              
Impacted Files Coverage Δ
...counts-locations/MockedAccountsLocationsAdapter.ts 100.00% <ø> (ø)
src/react/workflow/Workflows.tsx 72.85% <ø> (-0.39%) ⬇️
...hitecture/adapters/metrics/MockedMetricsAdapter.ts 90.90% <100.00%> (+1.43%) ⬆️
...act/next-architecture/domain/business/locations.ts 98.63% <100.00%> (+0.01%) ⬆️

... and 6 files with indirect coverage changes

@bert-e
Copy link
Contributor

bert-e commented Jun 5, 2023

Build failed

The build for commit did not succeed in branch w/2.0/bugfix/ZKUI-359.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jun 5, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/1.6

  • ✔️ development/2.0

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jun 5, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.6

  • ✔️ development/2.0

The following branches have NOT changed:

  • development/1.4
  • development/1.5

Please check the status of the associated issue ZKUI-359.

Goodbye monpote.

@bert-e bert-e merged commit e13cb7a into development/1.6 Jun 5, 2023
@bert-e bert-e deleted the bugfix/ZKUI-359 branch June 5, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants