ZKUI-364 - ability to delete non empty objects #607

hervedombya · 2023-06-14T16:43:44Z

Enregistrement.de.l.ecran.2023-07-05.a.11.24.08.mov

bert-e · 2023-06-14T16:43:47Z

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2023-06-14T16:43:55Z

Incorrect fix version

The Fix Version/s in issue ZKUI-364 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

1.6.16
2.0.10
2.1.0

Please check the Fix Version/s of ZKUI-364, or the target
branch of this pull request.

JBWatenbergScality

Pure UI review first:

the confirm input could be autofocus-ed when the modal is being opened
We should add a placeholder mentioning 'type confirm'
The status column in the summary should display the error message from the API
The table should be sorted by default on the status with the errors firstly displayed
For the column VersionId we should have a space between "Version" and "Id"
The warning banner icon should be exclamation-circle instead of the triangle (we are deprecating the triangle alternative)
The banner about governance bypass should only be displayed for object lock enabled buckets

Base Branch issue: I think this feature should target developement/2.1

General technical review:

We are missing unit tests fro the feature
We should try to make the feature redux-free

src/react/actions/s3bucket.ts

src/react/ui-elements/EmptyConfirmation/EmptyConfirmationFooter.tsx

src/react/ui-elements/EmptyConfirmation/EmptySummary.tsx

src/react/ui-elements/EmptyConfirmation/EmptySummaryList.tsx

src/react/ui-elements/EmptyConfirmation/useEmptyBucket.ts

bert-e · 2023-06-16T16:00:24Z

Incorrect fix version

The Fix Version/s in issue ZKUI-364 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

1.6.16
2.0.11
2.1.0

Please check the Fix Version/s of ZKUI-364, or the target
branch of this pull request.

bert-e · 2023-06-19T08:06:46Z

Incorrect fix version

The Fix Version/s in issue ZKUI-364 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

2.1.0

Please check the Fix Version/s of ZKUI-364, or the target
branch of this pull request.

src/react/databrowser/buckets/details/Overview.tsx

src/react/ui-elements/EmptyConfirmation/EmptySummary.tsx

src/react/ui-elements/EmptyConfirmation/useEmptyBucket.ts

codecov-commenter · 2023-06-20T09:37:09Z

Codecov Report

Merging #607 (c6b55b4) into development/2.1 (8c07eb6) will increase coverage by 0.11%.
The diff coverage is 66.25%.

@@                 Coverage Diff                 @@
##           development/2.1     #607      +/-   ##
===================================================
+ Coverage            54.47%   54.58%   +0.11%     
===================================================
  Files                  219      227       +8     
  Lines                10508    10726     +218     
  Branches              2961     3042      +81     
===================================================
+ Hits                  5724     5855     +131     
- Misses                4765     4851      +86     
- Partials                19       20       +1

Impacted Files	Coverage Δ
src/react/databrowser/buckets/details/Overview.tsx	`1.13% <0.00%> (-0.02%)`	⬇️
src/react/reducers/uiBuckets.ts	`55.55% <ø> (ø)`
...ui-elements/EmptyConfirmation/EmptySummaryList.tsx	`26.66% <26.66%> (ø)`
...t/ui-elements/EmptyConfirmation/chunkObjectList.ts	`28.57% <28.57%> (ø)`
...ct/ui-elements/EmptyConfirmation/useEmptyBucket.ts	`44.44% <44.44%> (ø)`
src/js/mock/S3ClientMSWHandlers.ts	`90.90% <62.50%> (-6.32%)`	⬇️
src/react/utils/IAMhooks.ts	`71.66% <62.50%> (+0.23%)`	⬆️
...react/next-architecture/domain/business/buckets.ts	`76.92% <63.63%> (-1.21%)`	⬇️
src/react/ui-elements/EmptyConfirmation/index.tsx	`67.94% <67.94%> (ø)`
src/react/queries.ts	`86.25% <70.96%> (-10.63%)`	⬇️
... and 5 more

... and 3 files with indirect coverage changes

src/react/queries.ts

src/react/ui-elements/EmptyConfirmation/EmptyConfirmationFooter.tsx

src/react/ui-elements/EmptyConfirmation/useEmptyBucket.ts

src/react/ui-elements/__tests__/EmptyConfirmation.test.tsx

src/react/ui-elements/__tests__/EmptySummary.test.tsx

src/react/ui-elements/DeleteBucket/index.tsx

src/react/ui-elements/EmptyBucket/EmptyBucketSummaryList.tsx

src/react/ui-elements/EmptyBucket/utils.ts

src/react/ui-elements/__tests__/EmptyBucket.test.tsx

Cuervino · 2023-07-06T08:48:30Z

I think we use the character " instead of ' in the UI content, so the modal title could be adapted.
At the Summary step, the button should be in Primary style, not Outline.
I would change the notification banner text like that:

The action of emptying can erase a maximum of 20 000 objects.
For buckets with a substantial number of objects, an expiration workflow (lifecycle rule) could provide an effective alternative for emptying the bucket.

Cuervino

Few minor comments.

hervedombya · 2023-07-06T09:19:03Z

I think we use the character " instead of ' in the UI content, so the modal title could be adapted.

At the Summary step, the button should be in Primary style, not Outline.

I would change the notification banner text like that:

The action of emptying can erase a maximum of 20 000 objects.
For buckets with a substantial number of objects, an expiration workflow (lifecycle rule) could provide an effective alternative for emptying the bucket.

upgrade confirm modal add test and made some changes in ui add summary and handle auto pagination review fixes and improvement minor change review fixes add some tests update empty confirm Update uiBuckets.ts update some ui elements add unit tests update tests update emptysummary objectLock instead of governancemode remove unused var review changes some improvement fix from review banner when delete is too big modify useEmptyBucket empty summary test update empty confirmation remove chunkobject push fix on useAwSInfinity fix tests minor fixes add utils test review fixes add new tests for empty bucket review fixes add mockobject empty add unique message test update empty bucket test review fixes fix some tests

JBWatenbergScality

LGTM !!

bert-e · 2023-07-07T13:08:19Z

Incorrect fix version

The Fix Version/s in issue ZKUI-364 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

2.1.0

Please check the Fix Version/s of ZKUI-364, or the target
branch of this pull request.

The following options are set: approve

hervedombya · 2023-07-07T13:35:54Z

/approve

hervedombya · 2023-07-07T15:05:20Z

/status

bert-e · 2023-07-07T15:05:24Z

Status

Status report is not available.

The following options are set: approve

bert-e · 2023-07-07T15:05:31Z

Incorrect fix version

The Fix Version/s in issue ZKUI-364 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

2.1.0

Please check the Fix Version/s of ZKUI-364, or the target
branch of this pull request.

The following options are set: approve

hervedombya · 2023-07-07T15:08:27Z

/status

bert-e · 2023-07-07T15:08:31Z

Status

Status report is not available.

The following options are set: approve

bert-e · 2023-07-07T15:08:41Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.1

The following branches will NOT be impacted:

development/1.4
development/1.5
development/1.6
development/2.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2023-07-07T15:08:50Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.1

The following branches have NOT changed:

development/1.4
development/1.5
development/1.6
development/2.0

Please check the status of the associated issue ZKUI-364.

Goodbye hervedombya.

JBWatenbergScality requested changes Jun 14, 2023

View reviewed changes

hervedombya force-pushed the feature/ZKUI-364-ability-to-delete-non-empty-objects branch from 9d51d51 to c1432e8 Compare June 16, 2023 16:09

hervedombya changed the base branch from development/1.6 to development/2.1 June 19, 2023 08:06

JBWatenbergScality reviewed Jun 19, 2023

View reviewed changes

src/react/databrowser/buckets/details/Overview.tsx Outdated Show resolved Hide resolved

src/react/ui-elements/EmptyConfirmation/EmptySummary.tsx Outdated Show resolved Hide resolved

src/react/ui-elements/EmptyConfirmation/useEmptyBucket.ts Outdated Show resolved Hide resolved

hervedombya force-pushed the feature/ZKUI-364-ability-to-delete-non-empty-objects branch 3 times, most recently from 4fa68ed to 9138814 Compare June 20, 2023 09:25

hervedombya force-pushed the feature/ZKUI-364-ability-to-delete-non-empty-objects branch 5 times, most recently from 9433ebf to b29c815 Compare June 21, 2023 12:50

JBWatenbergScality reviewed Jun 21, 2023

View reviewed changes

hervedombya force-pushed the feature/ZKUI-364-ability-to-delete-non-empty-objects branch 4 times, most recently from 28cc9e3 to e2304c0 Compare June 29, 2023 12:26

hervedombya force-pushed the feature/ZKUI-364-ability-to-delete-non-empty-objects branch 8 times, most recently from b4ea940 to 0368bf1 Compare July 3, 2023 16:29

hervedombya force-pushed the feature/ZKUI-364-ability-to-delete-non-empty-objects branch 2 times, most recently from 33b59a9 to 688dba6 Compare July 4, 2023 11:35

hervedombya requested a review from Cuervino July 4, 2023 15:30

hervedombya force-pushed the feature/ZKUI-364-ability-to-delete-non-empty-objects branch 2 times, most recently from 6f41741 to 7fe37b8 Compare July 5, 2023 07:47

JBWatenbergScality reviewed Jul 5, 2023

View reviewed changes

hervedombya force-pushed the feature/ZKUI-364-ability-to-delete-non-empty-objects branch 3 times, most recently from 8297708 to dd967ad Compare July 6, 2023 08:16

Cuervino approved these changes Jul 6, 2023

View reviewed changes

hervedombya closed this Jul 6, 2023

hervedombya reopened this Jul 6, 2023

hervedombya force-pushed the feature/ZKUI-364-ability-to-delete-non-empty-objects branch from 8b2e859 to 30ff68b Compare July 6, 2023 09:20

hervedombya force-pushed the feature/ZKUI-364-ability-to-delete-non-empty-objects branch from 4f9d1db to ad9a7af Compare July 6, 2023 15:32

JBWatenbergScality approved these changes Jul 7, 2023

View reviewed changes

bert-e merged commit ad9a7af into development/2.1 Jul 7, 2023

bert-e deleted the feature/ZKUI-364-ability-to-delete-non-empty-objects branch July 7, 2023 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ZKUI-364 - ability to delete non empty objects #607

ZKUI-364 - ability to delete non empty objects #607

hervedombya commented Jun 14, 2023 •

edited

Loading

bert-e commented Jun 14, 2023

bert-e commented Jun 14, 2023

JBWatenbergScality left a comment •

edited

Loading

bert-e commented Jun 16, 2023

bert-e commented Jun 19, 2023

codecov-commenter commented Jun 20, 2023 •

edited

Loading

Cuervino commented Jul 6, 2023

Cuervino left a comment

hervedombya commented Jul 6, 2023

JBWatenbergScality left a comment

bert-e commented Jul 7, 2023

hervedombya commented Jul 7, 2023

hervedombya commented Jul 7, 2023

bert-e commented Jul 7, 2023

bert-e commented Jul 7, 2023

hervedombya commented Jul 7, 2023

bert-e commented Jul 7, 2023

bert-e commented Jul 7, 2023

bert-e commented Jul 7, 2023

ZKUI-364 - ability to delete non empty objects #607

ZKUI-364 - ability to delete non empty objects #607

Conversation

hervedombya commented Jun 14, 2023 • edited Loading

bert-e commented Jun 14, 2023

Hello hervedombya,

bert-e commented Jun 14, 2023

Incorrect fix version

JBWatenbergScality left a comment • edited Loading

Choose a reason for hiding this comment

bert-e commented Jun 16, 2023

Incorrect fix version

bert-e commented Jun 19, 2023

Incorrect fix version

codecov-commenter commented Jun 20, 2023 • edited Loading

Codecov Report

Cuervino commented Jul 6, 2023

Cuervino left a comment

Choose a reason for hiding this comment

hervedombya commented Jul 6, 2023

JBWatenbergScality left a comment

Choose a reason for hiding this comment

bert-e commented Jul 7, 2023

Incorrect fix version

hervedombya commented Jul 7, 2023

hervedombya commented Jul 7, 2023

bert-e commented Jul 7, 2023

Status

bert-e commented Jul 7, 2023

Incorrect fix version

hervedombya commented Jul 7, 2023

bert-e commented Jul 7, 2023

Status

bert-e commented Jul 7, 2023

In the queue

bert-e commented Jul 7, 2023

hervedombya commented Jun 14, 2023 •

edited

Loading

JBWatenbergScality left a comment •

edited

Loading

codecov-commenter commented Jun 20, 2023 •

edited

Loading