ZKUI-369: identity-group-names-become-long #616

hervedombya · 2023-07-05T14:53:38Z

bert-e · 2023-07-05T14:53:41Z

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2023-07-05T14:53:46Z

Incorrect fix version

The Fix Version/s in issue ZKUI-369 contains:

2.0.2

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

2.1.0

Please check the Fix Version/s of ZKUI-369, or the target
branch of this pull request.

codecov-commenter · 2023-07-07T16:17:43Z

Codecov Report

Merging #616 (a177fd8) into development/2.1 (ad9a7af) will decrease coverage by 0.25%.
The diff coverage is 35.29%.

@@                 Coverage Diff                 @@
##           development/2.1     #616      +/-   ##
===================================================
- Coverage            55.48%   55.23%   -0.25%     
===================================================
  Files                  227      227              
  Lines                10753    10755       +2     
  Branches              3039     3040       +1     
===================================================
- Hits                  5966     5941      -25     
- Misses                4768     4795      +27     
  Partials                19       19

Impacted Files	Coverage Δ
src/react/account/AccountList.tsx	`86.20% <0.00%> (ø)`
src/react/databrowser/buckets/BucketList.tsx	`2.08% <0.00%> (ø)`
src/react/databrowser/buckets/details/Overview.tsx	`1.49% <ø> (ø)`
src/react/databrowser/buckets/details/Workflow.tsx	`3.33% <0.00%> (ø)`
src/react/account/AccountPoliciesList.tsx	`90.65% <100.00%> (+0.17%)`	⬆️
src/react/workflow/WorkflowList.tsx	`81.48% <100.00%> (ø)`

... and 6 files with indirect coverage changes

bert-e · 2023-07-10T08:25:38Z

Incorrect fix version

The Fix Version/s in issue ZKUI-369 contains:

2.0.2
2.1.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

2.1.0

Please check the Fix Version/s of ZKUI-369, or the target
branch of this pull request.

hervedombya · 2023-07-10T08:44:08Z

/status

bert-e · 2023-07-10T08:44:12Z

Status

Status report is not available.

bert-e · 2023-07-10T08:44:21Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2023-07-10T11:56:51Z

Conflict

There is a conflict between your branch improvement/ZKUI-369-identity-group-names-become-long and the
destination branch development/2.1.

Please resolve the conflict on the feature branch (improvement/ZKUI-369-identity-group-names-become-long).

git fetch && \
git checkout origin/improvement/ZKUI-369-identity-group-names-become-long && \
git merge origin/development/2.1

Resolve merge conflicts and commit

git push origin HEAD:improvement/ZKUI-369-identity-group-names-become-long

bert-e · 2023-07-10T11:57:49Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2023-07-10T14:13:10Z

Conflict

There is a conflict between your branch improvement/ZKUI-369-identity-group-names-become-long and the
destination branch development/2.1.

Please resolve the conflict on the feature branch (improvement/ZKUI-369-identity-group-names-become-long).

git fetch && \
git checkout origin/improvement/ZKUI-369-identity-group-names-become-long && \
git merge origin/development/2.1

Resolve merge conflicts and commit

git push origin HEAD:improvement/ZKUI-369-identity-group-names-become-long

bert-e · 2023-07-10T14:18:17Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

src/react/endpoint/EndpointList.tsx

bert-e · 2023-07-10T16:29:15Z

Conflict

There is a conflict between your branch improvement/ZKUI-369-identity-group-names-become-long and the
destination branch development/2.1.

Please resolve the conflict on the feature branch (improvement/ZKUI-369-identity-group-names-become-long).

git fetch && \
git checkout origin/improvement/ZKUI-369-identity-group-names-become-long && \
git merge origin/development/2.1

Resolve merge conflicts and commit

git push origin HEAD:improvement/ZKUI-369-identity-group-names-become-long

upgrade confirm modal add test and made some changes in ui add summary and handle auto pagination review fixes and improvement minor change review fixes add some tests update empty confirm Update uiBuckets.ts update some ui elements add unit tests update tests update emptysummary objectLock instead of governancemode remove unused var review changes some improvement fix from review banner when delete is too big modify useEmptyBucket empty summary test update empty confirmation remove chunkobject push fix on useAwSInfinity fix tests minor fixes add utils test review fixes add new tests for empty bucket review fixes add mockobject empty add unique message test update empty bucket test review fixes fix some tests ZKUI-364 - ability to delete non empty objects upgrade confirm modal add test and made some changes in ui add summary and handle auto pagination review fixes and improvement minor change review fixes add some tests update empty confirm Update uiBuckets.ts update some ui elements add unit tests update tests update emptysummary objectLock instead of governancemode remove unused var review changes some improvement fix from review banner when delete is too big modify useEmptyBucket empty summary test update empty confirmation remove chunkobject push fix on useAwSInfinity fix tests minor fixes add utils test review fixes add new tests for empty bucket review fixes add mockobject empty add unique message test update empty bucket test review fixes fix some tests ZKUI-364 - ability to delete non empty objects upgrade confirm modal add test and made some changes in ui add summary and handle auto pagination review fixes and improvement minor change review fixes add some tests update empty confirm Update uiBuckets.ts update some ui elements add unit tests update tests update emptysummary objectLock instead of governancemode remove unused var review changes some improvement fix from review banner when delete is too big modify useEmptyBucket empty summary test update empty confirmation remove chunkobject push fix on useAwSInfinity fix tests minor fixes add utils test review fixes add new tests for empty bucket review fixes add mockobject empty add unique message test update empty bucket test review fixes fix some tests ZKUI-364 - ability to delete non empty objects upgrade confirm modal add test and made some changes in ui add summary and handle auto pagination review fixes and improvement minor change review fixes add some tests update empty confirm Update uiBuckets.ts update some ui elements add unit tests update tests update emptysummary objectLock instead of governancemode remove unused var review changes some improvement fix from review banner when delete is too big modify useEmptyBucket empty summary test update empty confirmation remove chunkobject push fix on useAwSInfinity fix tests minor fixes add utils test review fixes add new tests for empty bucket review fixes add mockobject empty add unique message test update empty bucket test review fixes fix some tests ZKUI-364 - ability to delete non empty objects upgrade confirm modal add test and made some changes in ui add summary and handle auto pagination review fixes and improvement minor change review fixes add some tests update empty confirm Update uiBuckets.ts update some ui elements add unit tests update tests update emptysummary objectLock instead of governancemode remove unused var review changes some improvement fix from review banner when delete is too big modify useEmptyBucket empty summary test update empty confirmation remove chunkobject push fix on useAwSInfinity fix tests minor fixes add utils test review fixes add new tests for empty bucket review fixes add mockobject empty add unique message test update empty bucket test review fixes fix some tests ZKUI-369: identity-group-names-become-long fix account policies and workflow list add in modal title fix Overview fix workflow overview and endpointlist add wrap in endpointlist

bert-e · 2023-07-10T16:29:44Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

JBWatenbergScality

LGTM !

hervedombya · 2023-07-11T09:17:16Z

/approve

bert-e · 2023-07-11T09:17:26Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.1

The following branches will NOT be impacted:

development/1.4
development/1.5
development/1.6
development/2.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2023-07-11T09:17:36Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.1

The following branches have NOT changed:

development/1.4
development/1.5
development/1.6
development/2.0

Please check the status of the associated issue ZKUI-369.

Goodbye hervedombya.

hervedombya marked this pull request as draft July 5, 2023 14:53

hervedombya force-pushed the improvement/ZKUI-369-identity-group-names-become-long branch 3 times, most recently from 34f97b7 to a29b045 Compare July 7, 2023 16:06

hervedombya marked this pull request as ready for review July 10, 2023 08:01

hervedombya force-pushed the improvement/ZKUI-369-identity-group-names-become-long branch 3 times, most recently from aeb316c to a177fd8 Compare July 10, 2023 08:16

hervedombya force-pushed the improvement/ZKUI-369-identity-group-names-become-long branch from 2e2db24 to e0293ec Compare July 10, 2023 11:56

hervedombya force-pushed the improvement/ZKUI-369-identity-group-names-become-long branch from e0293ec to d91459e Compare July 10, 2023 11:57

hervedombya force-pushed the improvement/ZKUI-369-identity-group-names-become-long branch from 5a75d37 to 45d54ee Compare July 10, 2023 14:13

hervedombya force-pushed the improvement/ZKUI-369-identity-group-names-become-long branch from 45d54ee to d0bb354 Compare July 10, 2023 14:18

JBWatenbergScality reviewed Jul 10, 2023

View reviewed changes

src/react/endpoint/EndpointList.tsx Outdated Show resolved Hide resolved

hervedombya force-pushed the improvement/ZKUI-369-identity-group-names-become-long branch from d1d0dee to f7e6f9f Compare July 10, 2023 16:29

hervedombya force-pushed the improvement/ZKUI-369-identity-group-names-become-long branch from f7e6f9f to 5d8e1a8 Compare July 10, 2023 16:29

JBWatenbergScality approved these changes Jul 11, 2023

View reviewed changes

bert-e merged commit 5d8e1a8 into development/2.1 Jul 11, 2023

bert-e deleted the improvement/ZKUI-369-identity-group-names-become-long branch July 11, 2023 09:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ZKUI-369: identity-group-names-become-long #616

ZKUI-369: identity-group-names-become-long #616

hervedombya commented Jul 5, 2023 •

edited

Loading

bert-e commented Jul 5, 2023

bert-e commented Jul 5, 2023

codecov-commenter commented Jul 7, 2023 •

edited

Loading

bert-e commented Jul 10, 2023

hervedombya commented Jul 10, 2023

bert-e commented Jul 10, 2023

bert-e commented Jul 10, 2023

bert-e commented Jul 10, 2023

bert-e commented Jul 10, 2023

bert-e commented Jul 10, 2023

bert-e commented Jul 10, 2023

bert-e commented Jul 10, 2023

bert-e commented Jul 10, 2023

JBWatenbergScality left a comment

hervedombya commented Jul 11, 2023

bert-e commented Jul 11, 2023

bert-e commented Jul 11, 2023

ZKUI-369: identity-group-names-become-long #616

ZKUI-369: identity-group-names-become-long #616

Conversation

hervedombya commented Jul 5, 2023 • edited Loading

bert-e commented Jul 5, 2023

Hello hervedombya,

bert-e commented Jul 5, 2023

Incorrect fix version

codecov-commenter commented Jul 7, 2023 • edited Loading

Codecov Report

bert-e commented Jul 10, 2023

Incorrect fix version

hervedombya commented Jul 10, 2023

bert-e commented Jul 10, 2023

Status

bert-e commented Jul 10, 2023

Waiting for approval

bert-e commented Jul 10, 2023

Conflict

bert-e commented Jul 10, 2023

Waiting for approval

bert-e commented Jul 10, 2023

Conflict

bert-e commented Jul 10, 2023

Waiting for approval

bert-e commented Jul 10, 2023

Conflict

bert-e commented Jul 10, 2023

Waiting for approval

JBWatenbergScality left a comment

Choose a reason for hiding this comment

hervedombya commented Jul 11, 2023

bert-e commented Jul 11, 2023

In the queue

bert-e commented Jul 11, 2023

hervedombya commented Jul 5, 2023 •

edited

Loading

codecov-commenter commented Jul 7, 2023 •

edited

Loading