Module Federation #619

MonPote · 2023-07-06T14:41:31Z

No description provided.

bert-e · 2023-07-06T14:41:34Z

Hello monpote,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2023-07-06T14:41:39Z

Incorrect fix version

The Fix Version/s in issue ZKUI-371 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

2.1.0

Please check the Fix Version/s of ZKUI-371, or the target
branch of this pull request.

codecov-commenter · 2023-07-06T14:50:44Z

Codecov Report

Merging #619 (01490d0) into development/2.1 (e62483a) will increase coverage by 0.91%.
The diff coverage is 48.81%.

@@                 Coverage Diff                 @@
##           development/2.1     #619      +/-   ##
===================================================
+ Coverage            57.23%   58.14%   +0.91%     
===================================================
  Files                  227      208      -19     
  Lines                10793    10152     -641     
  Branches              3061     2940     -121     
===================================================
- Hits                  6177     5903     -274     
+ Misses                4600     4233     -367     
  Partials                16       16

Files Changed	Coverage Δ
src/js/STSClient.ts	`0.00% <ø> (ø)`
src/js/config.ts	`100.00% <ø> (+6.25%)`	⬆️
src/js/managementClient.ts	`100.00% <ø> (ø)`
src/react/ManagementProvider.tsx	`40.00% <ø> (ø)`
src/react/account/AccountEditCommonLayout.tsx	`93.10% <ø> (ø)`
.../react/account/AccountRoleSelectButtonAndModal.tsx	`55.31% <ø> (ø)`
src/react/account/Accounts.tsx	`76.19% <ø> (ø)`
src/react/account/CreateAccountPolicy.tsx	`50.00% <ø> (ø)`
src/react/account/MultiAccountsIcon.tsx	`100.00% <ø> (ø)`
src/react/account/UpdateAccountPolicy.tsx	`63.63% <ø> (ø)`
... and 67 more

... and 34 files with indirect coverage changes

MonPote · 2023-09-19T15:26:58Z

ping

bert-e · 2023-09-19T15:27:10Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

ZKUI-371 - update webpack configs ZKUI-371 - update webpack's deps ZKUI-371 - fix build fix svg warning ZKUI-371 - fix security check fix dev webpack environnement fix monaco issue replace push from connected-react-router for history in react component remove navbar fix user creation fix grafana url fix all tests update core-ui fix rebase Remove legacy cypress tests fix linter errors make prod ready change public path fix sts endpoint fix debug fix change client endpoint Solve s3 proxy issues for object with keys containing urlencoded chars This commit is the integration of #554 fix s3client add basePath in s3client Fix security workflow fix test Add go template fix ci Remove index.html remove default to index.html fix basepath for zenko client

bert-e · 2023-09-21T17:00:52Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

MonPote · 2023-09-21T17:00:52Z

/approve

JBWatenbergScality

LGTM !

bert-e · 2023-09-21T17:10:21Z

Build failed

The build for commit did not succeed in branch improvement/ZKUI-371-upgrade-deps-for-to-prepare-module-federation.

The following options are set: approve

JBWatenbergScality · 2023-09-21T17:11:50Z

/status

bert-e · 2023-09-21T17:11:53Z

Status

Status report is not available.

The following options are set: approve

bert-e · 2023-09-21T17:12:02Z

Build failed

The build for commit did not succeed in branch improvement/ZKUI-371-upgrade-deps-for-to-prepare-module-federation.

The following options are set: approve

bert-e · 2023-09-21T17:44:07Z

Build failed

The build for commit did not succeed in branch improvement/ZKUI-371-upgrade-deps-for-to-prepare-module-federation.

The following options are set: approve

bert-e · 2023-09-25T13:46:12Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.1

The following branches will NOT be impacted:

development/1.4
development/1.5
development/1.6
development/2.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2023-09-25T13:46:23Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.1

The following branches have NOT changed:

development/1.4
development/1.5
development/1.6
development/2.0

Please check the status of the associated issue ZKUI-371.

Goodbye monpote.

MonPote force-pushed the improvement/ZKUI-371-upgrade-deps-for-to-prepare-module-federation branch from c8093c5 to 8b7e224 Compare July 6, 2023 16:15

MonPote marked this pull request as ready for review July 6, 2023 16:29

MonPote force-pushed the improvement/ZKUI-371-upgrade-deps-for-to-prepare-module-federation branch from 7c5946c to eb85fbc Compare July 7, 2023 13:34

MonPote changed the title ~~save~~ Module Federation Jul 17, 2023

MonPote force-pushed the improvement/ZKUI-371-upgrade-deps-for-to-prepare-module-federation branch 2 times, most recently from 8b53adb to f98c20d Compare July 25, 2023 13:31

MonPote force-pushed the improvement/ZKUI-371-upgrade-deps-for-to-prepare-module-federation branch 10 times, most recently from baa19aa to 80a2b15 Compare August 1, 2023 15:31

JBWatenbergScality force-pushed the improvement/ZKUI-371-upgrade-deps-for-to-prepare-module-federation branch from bceb8fa to 7eb1e2d Compare September 11, 2023 07:25

MonPote force-pushed the improvement/ZKUI-371-upgrade-deps-for-to-prepare-module-federation branch 3 times, most recently from f6bc6f7 to ee9db56 Compare September 19, 2023 15:08

MonPote force-pushed the improvement/ZKUI-371-upgrade-deps-for-to-prepare-module-federation branch from ee9db56 to 6a4efab Compare September 19, 2023 15:28

MonPote force-pushed the improvement/ZKUI-371-upgrade-deps-for-to-prepare-module-federation branch from 6a4efab to 25963f3 Compare September 21, 2023 17:00

JBWatenbergScality approved these changes Sep 21, 2023

View reviewed changes

MonPote force-pushed the improvement/ZKUI-371-upgrade-deps-for-to-prepare-module-federation branch from dcf3b78 to e69acfd Compare September 21, 2023 17:21

fix ci

01490d0

MonPote force-pushed the improvement/ZKUI-371-upgrade-deps-for-to-prepare-module-federation branch from e69acfd to 01490d0 Compare September 21, 2023 17:30

bert-e merged commit 01490d0 into development/2.1 Sep 25, 2023
15 checks passed

bert-e deleted the improvement/ZKUI-371-upgrade-deps-for-to-prepare-module-federation branch September 25, 2023 13:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Module Federation #619

Module Federation #619

MonPote commented Jul 6, 2023

bert-e commented Jul 6, 2023

bert-e commented Jul 6, 2023

codecov-commenter commented Jul 6, 2023 •

edited

Loading

MonPote commented Sep 19, 2023

bert-e commented Sep 19, 2023

bert-e commented Sep 21, 2023

MonPote commented Sep 21, 2023

JBWatenbergScality left a comment

bert-e commented Sep 21, 2023

JBWatenbergScality commented Sep 21, 2023

bert-e commented Sep 21, 2023

bert-e commented Sep 21, 2023

bert-e commented Sep 21, 2023

bert-e commented Sep 25, 2023

bert-e commented Sep 25, 2023

Module Federation #619

Module Federation #619

Conversation

MonPote commented Jul 6, 2023

bert-e commented Jul 6, 2023

Hello monpote,

bert-e commented Jul 6, 2023

Incorrect fix version

codecov-commenter commented Jul 6, 2023 • edited Loading

Codecov Report

MonPote commented Sep 19, 2023

bert-e commented Sep 19, 2023

Waiting for approval

bert-e commented Sep 21, 2023

Waiting for approval

MonPote commented Sep 21, 2023

JBWatenbergScality left a comment

Choose a reason for hiding this comment

bert-e commented Sep 21, 2023

Build failed

JBWatenbergScality commented Sep 21, 2023

bert-e commented Sep 21, 2023

Status

bert-e commented Sep 21, 2023

Build failed

bert-e commented Sep 21, 2023

Build failed

bert-e commented Sep 25, 2023

In the queue

bert-e commented Sep 25, 2023

codecov-commenter commented Jul 6, 2023 •

edited

Loading