Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZKUI-373 // disable list versions for veeam xml #629

Merged

Conversation

hervedombya
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Aug 21, 2023

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Aug 21, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Aug 22, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@codecov-commenter
Copy link

Codecov Report

Merging #629 (31bfd3e) into development/2.1 (060a9f7) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 31bfd3e differs from pull request most recent head e7a99f7. Consider uploading reports for the commit e7a99f7 to get more accurate results

@@                 Coverage Diff                 @@
##           development/2.1     #629      +/-   ##
===================================================
- Coverage            56.63%   56.58%   -0.05%     
===================================================
  Files                  227      227              
  Lines                10771    10774       +3     
  Branches              3060     3060              
===================================================
- Hits                  6100     6097       -3     
- Misses                4651     4657       +6     
  Partials                20       20              
Files Changed Coverage Δ
src/react/databrowser/objects/ObjectList.tsx 70.96% <100.00%> (-7.61%) ⬇️

... and 2 files with indirect coverage changes

@bert-e
Copy link
Contributor

bert-e commented Aug 23, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@hervedombya hervedombya force-pushed the bugfix/ZKUI-373-disable-list-versions-for-veeam-xml branch 2 times, most recently from 46ccb62 to db3e9dd Compare August 23, 2023 13:13
@hervedombya hervedombya force-pushed the bugfix/ZKUI-373-disable-list-versions-for-veeam-xml branch from f26b7d4 to a7ece5f Compare August 23, 2023 13:50
Copy link
Contributor

@MonPote MonPote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hervedombya
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Aug 23, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.1

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Aug 23, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.1

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0

Please check the status of the associated issue ZKUI-373.

Goodbye hervedombya.

@bert-e bert-e merged commit a7ece5f into development/2.1 Aug 23, 2023
11 of 13 checks passed
@bert-e bert-e deleted the bugfix/ZKUI-373-disable-list-versions-for-veeam-xml branch August 23, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants