Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZKUI-376: fix the workflow not visible on workflow page #634

Conversation

ChengYanJin
Copy link
Contributor

@ChengYanJin ChengYanJin commented Sep 4, 2023

The value of the form was not set correctly which cause the issue.

So we need to do reset the form value once we load workflow.

@bert-e
Copy link
Contributor

bert-e commented Sep 4, 2023

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Sep 4, 2023

Incorrect fix version

The Fix Version/s in issue ZKUI-376 contains:

  • 2.0.4

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.6.17

  • 2.0.12

  • 2.1.0

Please check the Fix Version/s of ZKUI-376, or the target
branch of this pull request.

@ChengYanJin ChengYanJin changed the base branch from development/1.6 to development/2.0 September 4, 2023 15:18
@bert-e
Copy link
Contributor

bert-e commented Sep 4, 2023

Incorrect fix version

The Fix Version/s in issue ZKUI-376 contains:

  • 2.0.4

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.0.12

  • 2.1.0

Please check the Fix Version/s of ZKUI-376, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Sep 4, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Sep 4, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Contributor

bert-e commented Sep 8, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@codecov-commenter
Copy link

Codecov Report

Merging #634 (38ea551) into development/2.0 (8087801) will increase coverage by 0.43%.
Report is 1 commits behind head on development/2.0.
The diff coverage is 77.77%.

@@                 Coverage Diff                 @@
##           development/2.0     #634      +/-   ##
===================================================
+ Coverage            55.62%   56.06%   +0.43%     
===================================================
  Files                  219      219              
  Lines                10522    10531       +9     
  Branches              2981     2984       +3     
===================================================
+ Hits                  5853     5904      +51     
+ Misses                4649     4611      -38     
+ Partials                20       16       -4     
Files Changed Coverage Δ
src/react/workflow/ExpirationForm.tsx 84.42% <ø> (+2.45%) ⬆️
src/react/workflow/ConfigurationTab.tsx 48.80% <71.42%> (+5.59%) ⬆️
src/js/mock/managementClientMSWHandlers.ts 85.71% <100.00%> (+0.18%) ⬆️
src/react/actions/account.ts 41.17% <100.00%> (+11.41%) ⬆️

... and 9 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@ChengYanJin
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Sep 11, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

Copy link
Contributor

@JBWatenbergScality JBWatenbergScality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@bert-e
Copy link
Contributor

bert-e commented Sep 12, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.0

  • ✔️ development/2.1

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Sep 12, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.0

  • ✔️ development/2.1

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6

Please check the status of the associated issue ZKUI-376.

Goodbye chengyanjin.

@bert-e bert-e merged commit 680dd7b into development/2.0 Sep 12, 2023
9 checks passed
@bert-e bert-e deleted the bugfix/ZKUI-376-fix-the-workflow-not-visible-on-workflow-page branch September 12, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants