Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZKUI-408 fix: Grafana URL is relative from the root of the URL #668

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

JBWatenbergScality
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Nov 8, 2023

Hello jbwatenbergscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 8, 2023

Incorrect fix version

The Fix Version/s in issue ZKUI-408 contains:

  • 2.1.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.1.6

  • 2.2.0

Please check the Fix Version/s of ZKUI-408, or the target
branch of this pull request.

@JBWatenbergScality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 8, 2023

Incorrect fix version

The Fix Version/s in issue ZKUI-408 contains:

  • 2.1.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.1.6

  • 2.2.0

Please check the Fix Version/s of ZKUI-408, or the target
branch of this pull request.

The following options are set: approve

@codecov-commenter
Copy link

Codecov Report

Merging #668 (6e94142) into development/2.1 (38effb5) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@                 Coverage Diff                 @@
##           development/2.1     #668      +/-   ##
===================================================
- Coverage            58.24%   58.16%   -0.08%     
===================================================
  Files                  208      208              
  Lines                10168    10168              
  Branches              2948     2948              
===================================================
- Hits                  5922     5914       -8     
- Misses                4230     4238       +8     
  Partials                16       16              
Files Coverage Δ
src/react/next-architecture/ui/ConfigProvider.tsx 14.81% <0.00%> (ø)

... and 4 files with indirect coverage changes

@JBWatenbergScality
Copy link
Contributor Author

/status

@bert-e
Copy link
Contributor

bert-e commented Nov 8, 2023

Status

Status report is not available.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 8, 2023

Integration data created

I have created the integration data for the additional destination branches.

  • this pull request will merge bugfix/ZKUI-408 into
    development/2.1
  • w/2.2/bugfix/ZKUI-408 will be merged into development/2.2

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 8, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 8, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.1

  • ✔️ development/2.2

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 8, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.1

  • ✔️ development/2.2

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0

Please check the status of the associated issue ZKUI-408.

Goodbye jbwatenbergscality.

@bert-e bert-e merged commit 6e94142 into development/2.1 Nov 8, 2023
16 checks passed
@bert-e bert-e deleted the bugfix/ZKUI-408 branch November 8, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants