ZKUI-390: Prepare all the mutation needed for Veeam #678

ChengYanJin · 2023-11-16T10:36:15Z

No description provided.

bert-e · 2023-11-16T10:36:18Z

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2023-11-16T10:36:27Z

Incorrect fix version

The Fix Version/s in issue ZKUI-390 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

2.2.0

Please check the Fix Version/s of ZKUI-390, or the target
branch of this pull request.

bert-e · 2023-11-16T14:08:09Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2023-11-17T10:45:09Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

codecov-commenter · 2023-11-17T10:51:49Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f01fda3) 58.70% compared to head (a629074) 59.43%.

Files	Patch %	Lines
src/react/ui-elements/Veeam/VeeamConstants.ts	85.71%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           development/2.2     #678      +/-   ##
===================================================
+ Coverage            58.70%   59.43%   +0.73%     
===================================================
  Files                  214      215       +1     
  Lines                10325    10378      +53     
  Branches              2984     2988       +4     
===================================================
+ Hits                  6061     6168     +107     
+ Misses                4247     4193      -54     
  Partials                17       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JBWatenbergScality · 2023-11-20T12:45:49Z

src/js/mutations.ts

+  const { getQuery } = useAssumeRoleQuery();
+  return useMutation({
+    mutationFn: (roleArn: string) => getQuery(roleArn).queryFn(),
+    onSuccess(_, variables) {
+      setRoleArnStored(variables);
+    },
+  });


I would useSetAssumeRole instead and return setRole among with it's result, also I would make setRole return the mutation object (without the mutate method, which would be replaced by the setRole one).

bert-e · 2023-11-20T12:45:59Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

JBWatenbergScality

LGTM !!!

ChengYanJin · 2023-11-20T17:36:15Z

/approve

bert-e · 2023-11-20T17:36:25Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.2

The following branches will NOT be impacted:

development/1.4
development/1.5
development/1.6
development/2.0
development/2.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2023-11-20T17:36:35Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.2

The following branches have NOT changed:

development/1.4
development/1.5
development/1.6
development/2.0
development/2.1

Please check the status of the associated issue ZKUI-390.

Goodbye chengyanjin.

ChengYanJin force-pushed the feature/ZKUI-390-prepare-all-the-mutations-use-by-veeam-configuration branch from 8ca92f4 to 9d20159 Compare November 16, 2023 13:42

ChengYanJin force-pushed the feature/ZKUI-390-prepare-all-the-mutations-use-by-veeam-configuration branch 3 times, most recently from adff480 to bfab4d0 Compare November 17, 2023 10:44

ChengYanJin force-pushed the feature/ZKUI-390-prepare-all-the-mutations-use-by-veeam-configuration branch 2 times, most recently from b54dca7 to beb1d40 Compare November 17, 2023 11:02

ChengYanJin marked this pull request as ready for review November 17, 2023 11:07

ChengYanJin force-pushed the feature/ZKUI-390-prepare-all-the-mutations-use-by-veeam-configuration branch from beb1d40 to a629074 Compare November 17, 2023 11:19

JBWatenbergScality reviewed Nov 20, 2023

View reviewed changes

ChengYanJin force-pushed the feature/ZKUI-390-prepare-all-the-mutations-use-by-veeam-configuration branch 2 times, most recently from 9fca480 to b776375 Compare November 20, 2023 15:44

ChengYanJin added 2 commits November 20, 2023 16:51

ZKUI-390: Prepare all the mutation needed for Veeam

0e0ed10

ZKUI-397: No error toast in case of getBucketTagging NotSuchTagSet

5c1a2bd

ChengYanJin force-pushed the feature/ZKUI-390-prepare-all-the-mutations-use-by-veeam-configuration branch from b776375 to 5c1a2bd Compare November 20, 2023 15:51

JBWatenbergScality approved these changes Nov 20, 2023

View reviewed changes

bert-e merged commit 5c1a2bd into development/2.2 Nov 20, 2023

bert-e deleted the feature/ZKUI-390-prepare-all-the-mutations-use-by-veeam-configuration branch November 20, 2023 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ZKUI-390: Prepare all the mutation needed for Veeam #678

ZKUI-390: Prepare all the mutation needed for Veeam #678

ChengYanJin commented Nov 16, 2023

bert-e commented Nov 16, 2023

bert-e commented Nov 16, 2023

bert-e commented Nov 16, 2023

bert-e commented Nov 17, 2023

codecov-commenter commented Nov 17, 2023 •

edited

Loading

JBWatenbergScality Nov 20, 2023

bert-e commented Nov 20, 2023

JBWatenbergScality left a comment

ChengYanJin commented Nov 20, 2023

bert-e commented Nov 20, 2023

bert-e commented Nov 20, 2023

ZKUI-390: Prepare all the mutation needed for Veeam #678

ZKUI-390: Prepare all the mutation needed for Veeam #678

Conversation

ChengYanJin commented Nov 16, 2023

bert-e commented Nov 16, 2023

Hello chengyanjin,

bert-e commented Nov 16, 2023

Incorrect fix version

bert-e commented Nov 16, 2023

Waiting for approval

bert-e commented Nov 17, 2023

Waiting for approval

codecov-commenter commented Nov 17, 2023 • edited Loading

Codecov Report

JBWatenbergScality Nov 20, 2023

Choose a reason for hiding this comment

bert-e commented Nov 20, 2023

Waiting for approval

JBWatenbergScality left a comment

Choose a reason for hiding this comment

ChengYanJin commented Nov 20, 2023

bert-e commented Nov 20, 2023

In the queue

bert-e commented Nov 20, 2023

codecov-commenter commented Nov 17, 2023 •

edited

Loading