Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/zk UI 414 create configuration overalay provider #679

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Feature/zk UI 414 create configuration overalay provider #679

merged 3 commits into from
Nov 20, 2023

Conversation

JBWatenbergScality
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Nov 17, 2023

Hello jbwatenbergscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 17, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023 •
edited
Loading

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (f01fda3) 58.70% compared to head (49d50ac) 58.71%.
Report is 2 commits behind head on development/2.2.

Files Patch % Lines
src/react/locations/LocationsList.tsx 0.00% 9 Missing ⚠️
src/react/locations/utils.tsx 27.27% 8 Missing ⚠️
src/react/account/AccountLocations.tsx 0.00% 1 Missing ⚠️
src/react/locations/LocationEditor.tsx 66.66% 1 Missing ⚠️
...e/ui/AccountsLocationsEndpointsAdapterProvider.tsx 92.30% 1 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           development/2.2     #679      +/-   ##
===================================================
+ Coverage            58.70%   58.71%   +0.01%     
===================================================
  Files                  214      214              
  Lines                10325    10336      +11     
  Branches              2984     2991       +7     
===================================================
+ Hits                  6061     6069       +8     
- Misses                4247     4250       +3     
  Partials                17       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

ChengYanJin
ChengYanJin approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

src/react/locations/LocationEditor.tsx Outdated
Comment on lines 34 to 36
import { useQueryClient } from 'react-query';
import { queries } from '../next-architecture/domain/business/locations';
import { useLocationAdapter } from '../next-architecture/ui/LocationAdapterProvider';
Copy link
Contributor

@ChengYanJin ChengYanJin Nov 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic comment: OPTION + SHIFT + O !

Copy link
Contributor Author

@JBWatenbergScality JBWatenbergScality Nov 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imagination-spongebob-squarepants-gif

@JBWatenbergScality
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.2

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@ChengYanJin
Copy link
Contributor

@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.2

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1

Please check the status of the associated issue ZKUI-414.

Goodbye jbwatenbergscality.

@bert-e bert-e merged commit ed76014 into development/2.2 Nov 20, 2023
@bert-e bert-e deleted the feature/ZKUI-414-create-configuration-overalay-provider branch November 20, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChengYanJin ChengYanJin ChengYanJin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JBWatenbergScality @bert-e @codecov-commenter @ChengYanJin