Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTESCA-11656: fix immutable backup #739

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

hervedombya
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Mar 18, 2024

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 18, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.25%. Comparing base (f0ade89) to head (36e9bfa).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/2.2     #739      +/-   ##
===================================================
- Coverage            59.32%   59.25%   -0.07%     
===================================================
  Files                  240      240              
  Lines                11317    11320       +3     
  Branches              3263     3266       +3     
===================================================
- Hits                  6714     6708       -6     
- Misses                4582     4591       +9     
  Partials                21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hervedombya hervedombya force-pushed the bugfix/ARTESCA-11656-fix-immutable-backup branch from 09236a9 to 36e9bfa Compare March 18, 2024 15:32
Fix enableImmutableBackup value in VeeamConfiguration
@hervedombya hervedombya force-pushed the bugfix/ARTESCA-11656-fix-immutable-backup branch from b790c36 to c9afd98 Compare March 18, 2024 15:53
Copy link
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for fixing the 365 label as well !

@hervedombya
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Mar 18, 2024

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.2

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 18, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.2

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1

Please check the status of the associated issue ARTESCA-11656.

Goodbye hervedombya.

@bert-e bert-e merged commit c9afd98 into development/2.2 Mar 18, 2024
14 of 15 checks passed
@bert-e bert-e deleted the bugfix/ARTESCA-11656-fix-immutable-backup branch March 18, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants