-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement/artesca 10990 expose account role selector with module federation #752
Improvement/artesca 10990 expose account role selector with module federation #752
Conversation
Hello monpote,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
afterAll(() => { | ||
server.close(); | ||
}); | ||
it('renders with normal props', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want an additional test where you change account and change roles for this account and check if the options of the role select matches
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
Co-authored-by: JBWatenbergScality <75977494+JBWatenbergScality@users.noreply.github.com>
Co-authored-by: JBWatenbergScality <75977494+JBWatenbergScality@users.noreply.github.com>
Co-authored-by: JBWatenbergScality <75977494+JBWatenbergScality@users.noreply.github.com>
78f690d
to
6d88be5
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
435d752
to
991fee7
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Yohoo!!!
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARTESCA-10990. Goodbye monpote. |
No description provided.