-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement/artesca 13354 office 365 v8 support #771
Improvement/artesca 13354 office 365 v8 support #771
Conversation
Hello jeanmarcmilletscality,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
6ad64e4
to
4236ec0
Compare
ConflictThere is a conflict between your branch Please resolve the conflict on the feature branch ( git fetch && \
git checkout origin/improvement/ARTESCA-13354-office-365-v8-support && \
git merge origin/development/3.0 Resolve merge conflicts and commit git push origin HEAD:improvement/ARTESCA-13354-office-365-v8-support |
4236ec0
to
5f7ab4a
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
veeamTagApplication === VeeamApplicationType.VEEAM_OFFICE_365 || | ||
veeamTagApplication === VeeamApplicationType.VEEAM_OFFICE_365_V8) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could be simplified [VeeamApplicationType.VEEAM_BACKUP_REPLICATION, VeeamApplicationType.VEEAM_OFFICE_365, VeeamApplicationType.VEEAM_OFFICE_365_V8].includes(veeamTagApplication)
. not necessary to do it now, just a dumb suggestion
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
/bypass_author_approval |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARTESCA-13354. Goodbye jeanmarcmilletscality. The following options are set: bypass_author_approval |
No description provided.