Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSET-4430: Fix flaky test on Windows #50

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

martin-majlis-s1
Copy link
Collaborator

Jira Link: https://sentinelone.atlassian.net/browse/4430}

🥅 Goal

When tests are executed on Windows, there is a flaky test - open-telemetry/opentelemetry-collector-contrib#25094 - so lets run the library tests on Windows as well.

🛠️ Solution

Add GitHub action that runs tests on all supported version - https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#choosing-github-hosted-runners

🏫 Testing

Check that GHA is running those tests.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #50 (c0be703) into main (0ee6bc1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   74.29%   74.29%           
=======================================
  Files          11       11           
  Lines        1622     1622           
=======================================
  Hits         1205     1205           
  Misses        351      351           
  Partials       66       66           

Copy link
Collaborator

@tomaz-s1 tomaz-s1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@martin-majlis-s1
Copy link
Collaborator Author

On Windows:

=== RUN   TestAddEventWithShouldSendAge
--- PASS: TestAddEventWithShouldSendAge (0.53s)
=== RUN   TestAddEventWithShouldSendSize
--- PASS: TestAddEventWithShouldSendSize (198.48s)

on my machine:

=== RUN   TestAddEventWithShouldSendAge
--- PASS: TestAddEventWithShouldSendAge (0.46s)
=== RUN   TestAddEventWithShouldSendSize
--- PASS: TestAddEventWithShouldSendSize (0.44s)

I am not surprised, that some of the tests are 3-4 times slower on my testing EC2 instance, but it's really strange that this single test is 200x slower.

@martin-majlis-s1
Copy link
Collaborator Author

martin-majlis-s1 commented Aug 10, 2023

When I check the pipelines here:

So although this particular test is about 160s slower on Windows, the overall difference is just 70s, so other tests has to be faster.

@martin-majlis-s1 martin-majlis-s1 added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit 8b15cc1 Aug 10, 2023
@martin-majlis-s1 martin-majlis-s1 deleted the DSET-4430-run-tests-in-multiple-os branch August 10, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants