-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSET-4430: Fix flaky test on Windows #50
Conversation
Codecov Report
@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 74.29% 74.29%
=======================================
Files 11 11
Lines 1622 1622
=======================================
Hits 1205 1205
Misses 351 351
Partials 66 66 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
On Windows:
on my machine:
I am not surprised, that some of the tests are 3-4 times slower on my testing EC2 instance, but it's really strange that this single test is 200x slower. |
When I check the pipelines here:
So although this particular test is about 160s slower on Windows, the overall difference is just 70s, so other tests has to be faster. |
Jira Link: https://sentinelone.atlassian.net/browse/4430}
🥅 Goal
When tests are executed on Windows, there is a flaky test - open-telemetry/opentelemetry-collector-contrib#25094 - so lets run the library tests on Windows as well.
🛠️ Solution
Add GitHub action that runs tests on all supported version - https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#choosing-github-hosted-runners
🏫 Testing
Check that GHA is running those tests.