Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSET-4456: Use Go 1.20 and not 1.2 in CI/CD pipeline #54

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

martin-majlis-s1
Copy link
Collaborator

Jira Link: https://sentinelone.atlassian.net/browse/DSET-4456

🥅 Goal

In the PR #53 I have switched Go version from 1.19 to to 1.20. But there is some GHA feature, that it treats as 1.2. This can be seen in the Dependabot PR - https://github.com/scalyr/dataset-go/actions/runs/5960922153/job/16169141080?pr=49#step:4:31 - which has failed because some tools cannot be installed with Go 1.2.

But when I check the same action in the PR #53 - it has failed - https://github.com/scalyr/dataset-go/actions/runs/5952594475/job/16144912841. I have enabled auto merge, but I haven't expected, that it will be merged, when there is some failing action.

Screenshot 2023-08-24 at 9 59 23

🛠️ Solution

Fix the notation so that Go 1.20 is used instead of 1.2

🏫 Testing

Check that the pipeline succeeds.

@codecov-commenter
Copy link

Codecov Report

Merging #54 (97d1f02) into main (68a857c) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   75.13%   75.13%           
=======================================
  Files          12       12           
  Lines        1713     1713           
=======================================
  Hits         1287     1287           
  Misses        359      359           
  Partials       67       67           

@martin-majlis-s1
Copy link
Collaborator Author

After the PR is created it takes some time before the pipelines are triggered. And based on the UI it looks that it's possible to merge it when approved even without successful GHA.

Screenshot 2023-08-24 at 10 01 29

@martin-majlis-s1 martin-majlis-s1 added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit 61547e7 Aug 24, 2023
@martin-majlis-s1 martin-majlis-s1 deleted the DSET-4456-fix-code-quality branch August 24, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants