Metrics: add attributes and switch to snake_case #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link: https://sentinelone.atlassian.net/browse/DSET-4558
🥅 Goal
I have received feedback in the PR in the Otel Contrib - open-telemetry/opentelemetry-collector-contrib#29446 (comment) that:
snake_case
🛠️ Solution
I have renamed the metrics as well as introduced possibility to pass the processing entities as well as name.
🏫 Testing
Same as in the PR #61
But add more dataset exporters in the demo repository -
src/otelcollector/otelcol-config.yml
We can see, that metrics are now
snake_case
:And it's possible to separate metrics based on
entity
(logs/traces) andname
: