Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics: add attributes and switch to snake_case #63

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

martin-majlis-s1
Copy link
Collaborator

@martin-majlis-s1 martin-majlis-s1 commented Nov 27, 2023

Jira Link: https://sentinelone.atlassian.net/browse/DSET-4558

🥅 Goal

I have received feedback in the PR in the Otel Contrib - open-telemetry/opentelemetry-collector-contrib#29446 (comment) that:

  • metric names should be snake_case
  • there should be support for attributes

🛠️ Solution

I have renamed the metrics as well as introduced possibility to pass the processing entities as well as name.

🏫 Testing

Same as in the PR #61

But add more dataset exporters in the demo repository - src/otelcollector/otelcol-config.yml

service:
  pipelines:
    traces:
      receivers: [otlp]
      processors: [batch, attributes]
      exporters: [otlp, debug, spanmetrics, dataset, dataset/aaa, dataset/bbb, dataset/ccc, dataset/ddd]
    metrics:
      receivers: [httpcheck/frontendproxy, otlp, spanmetrics, prometheus]
      processors: [filter/ottl, transform, batch]
      exporters: [otlphttp/prometheus, debug]
    logs:
      receivers: [otlp]
      processors: [batch, attributes]
      exporters: [otlp/logs, debug, dataset, dataset/aaa, dataset/bbb, dataset/ccc, dataset/ddd]

We can see, that metrics are now snake_case:
Screenshot 2023-11-27 at 12 29 29

And it's possible to separate metrics based on entity (logs/traces) and name:
Screenshot 2023-11-27 at 12 59 10

@martin-majlis-s1 martin-majlis-s1 merged commit 04a2025 into main Nov 27, 2023
10 checks passed
@martin-majlis-s1 martin-majlis-s1 deleted the metrics-add-attributes branch November 27, 2023 12:27
Copy link
Collaborator

@tomaz-s1 tomaz-s1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing the upstream feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants