Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut to open note in a new split pane (Issue #202) #358

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

pricebaldwin
Copy link
Contributor

@pricebaldwin pricebaldwin commented Mar 28, 2024

This adds the shortcut cmd/ctrl + alt + enter to the search modal to open a found file in a new leaf. I used the term "split" in user-facing text, because I think that's the more common nomenclature.

Some things to note:

  • This function ignores the existing "open in new pane by default" setting. I didn't seem relevant with this action.
  • It also does not check to see if the file is already open. It will continue opening the value in a new split as often as the user wants.
  • As-is it will always split to the immediate right.

This adds the shortcut `cmd/ctrl + alt + enter` to the search modal to open a found file in a new leaf. I used the term "split" in user-facing text, because I think that's the more common

Some things to note:
- This function ignores the existing "open in new pane by default" setting.
- It also does not check to see if the file is already open. It will continue opening the value in a new split as often as the user wants.
@pricebaldwin pricebaldwin changed the title Add shortcut to open note in a new split pane (PR #202) Add shortcut to open note in a new split pane (Issue #202) Mar 28, 2024
@scambier scambier changed the base branch from master to develop March 29, 2024 20:40
@scambier
Copy link
Owner

Thanks for your PR :)

@scambier scambier merged commit f86736e into scambier:develop Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants