Save/load index to files, improve logging #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your work. Like I said in the original issue, could you please also put this new behavior behind a toggleable opt-in setting? I'd rather keep the current behavior as the default, while we're testing this for a few weeks 👍 |
|
@scambier ready |
|
Looks good, thanks again. I'll make a first beta release this week :) |
|
@mnaoumov I forgot to ask the most important question: how are the performances after this PR? |
|
@scambier the performance improved greatly. My vault is pretty big
Preloading them saves tons of startup time. And this is especially extremely performant on mobile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62