#96: move weburl logic from template #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR introduced a callback functions for sarif module and to-html command.
sarif and git modules don't know anything about vcs web url structure. And this callback function allows to move this logic right inside main command. It also allowed us to remove web url logic from html templates. So html template are vcs agnostic now.
The functions that were introduced in to-html (buildWebURLToBranch, buildWebURLToCommit), runtime callback function (locationWebURLCallback) and existing (gitURLtoWebURL) should be used in future for vcs specific logic.
For now generic logic was introduced, that should work for most cloud vcs solutions (gitlab, github, bitbucket cloud).