Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing $variables fix #16

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Missing $variables fix #16

merged 1 commit into from
Sep 10, 2021

Conversation

riha112
Copy link
Contributor

@riha112 riha112 commented Sep 10, 2021

Original issue:

Problem:

  • Virtual type filter isn't passing variable $variaibles while DI isn't rebuilded.

In this PR:

  • Added default value for $variables

@riha112 riha112 changed the title Missing fix Missing $variables fix Sep 10, 2021
@riha112 riha112 mentioned this pull request Sep 10, 2021
Closed
@carinadues carinadues merged commit bc80aa8 into scandipwa:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zans-laksa zans-laksa zans-laksa approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riha112 @zans-laksa @carinadues