Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product Disable Fix on PDP #35

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Product Disable Fix on PDP #35

merged 1 commit into from
Apr 4, 2024

Conversation

Talha7717
Copy link
Contributor

@Talha7717 Talha7717 commented Dec 21, 2023 •
edited
Loading

Issue(s) at hand:

  • Addresses the problem of the Product Page displaying as blank when the product is disabled. Issue #5431.

Problem Statement:

  • The Product Page exhibits a blank display when the associated product is disabled.

Changes in this Pull Request (PR):

  • The product page now redirects to a 404 error page if the product is disabled. This occurs when users access the page directly via URL or through external sources like Facebook.

AleksandrsKondratjevs
AleksandrsKondratjevs approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@AleksandrsKondratjevs AleksandrsKondratjevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AleksandrsKondratjevs AleksandrsKondratjevs merged commit 08e3227 into scandipwa:master Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksandrsKondratjevs AleksandrsKondratjevs AleksandrsKondratjevs approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Talha7717 @AleksandrsKondratjevs