-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setuputils script for py bindings #51
Conversation
Thanks! It's a good idea to make this properly installable! I think we want to fill in a bit more details, e.g. license, use README.md as a readme, etc. Could you adapt Lines 215 to 230 in 6c3ae36
into a small |
Here's a bit more context for what we want to do in the future: eventually we want to package the pre-built shared library
Building these platform dependant libraries is a bit more involved, though. The common way to do it for Linux is to spawn up a Docker container with an old libc, build the library there (for compatibility), and distribute it. For macOS and Windows it may be a bit easier. Anyway, that's just to give some context of our future plans. |
It sounds like PyPI doesn't allow Linux wheels right now, so I don't think there's a way to include a compiled |
Hm not sure where you got the information from that PyPI does not support Linux wheels. I think what we have to do is build the shared library on a "old enough" system (CentOS 5) and restrict us a bit for the wheels to be part of the These wheels work happily on basically all Linux systems currently out there. At least the ones we care about having binary builds for. It would be perfect if we could let Travis CI build those wheels in a Docker container for master. I'd like to split the wheels discussion off of your pull request, though. If that is fine with you. Can you squash and rebase your branch, then I'd like to merge it into master. |
7ff961b
to
f7120db
Compare
It's squashed and rebased on |
Thank you! Happily merging now! :) |
Python packages usually have a
setup.py
included to install the scripts.