Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PredefIterableIsMutable doesn't apply to Scala 2.13. #289

Closed
mwz opened this issue Mar 7, 2020 · 3 comments · Fixed by #708
Closed

PredefIterableIsMutable doesn't apply to Scala 2.13. #289

mwz opened this issue Mar 7, 2020 · 3 comments · Fixed by #708

Comments

@mwz
Copy link
Contributor

mwz commented Mar 7, 2020 •
edited
Loading

The PredefIterableIsMutable rule no longer applies to Scala 2.13 as Iterable now aliases scala.collection.Iterable which in turn delegates to immutable.Iterable.

The same applies to PredefSeqIsMutable.

This rule should be ignored in 2.13.
@mwz mwz changed the title PredefIterableIsMutable doesn't apply to Scala 2.13. PredefIterableIsMutable and PredefSeqIsMutable don't apply to Scala 2.13. Mar 7, 2020
@mccartney
Copy link
Collaborator

Similar to #294

@mwz
Copy link
Contributor Author

mwz commented Mar 9, 2020

There is this that we could use.

@saeltz saeltz mentioned this issue May 26, 2021
Merged
@saeltz
Copy link
Collaborator

saeltz commented Nov 19, 2022

PredefSeqIsMutable is already disabled for Scala 2.13: https://github.com/sksamuel/scapegoat/blob/5c690f685632d4b784fb0a187ef0091ec395a233/src/main/scala/com/sksamuel/scapegoat/inspections/collections/PredefSeqIsMutable.scala#L16

@saeltz saeltz changed the title PredefIterableIsMutable and PredefSeqIsMutable don't apply to Scala 2.13. PredefIterableIsMutable doesn't apply to Scala 2.13. Nov 19, 2022
@saeltz saeltz mentioned this issue Nov 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PredefTraversableIsMutable & PredefIterableIsMutable don't apply on Scala 2.13 saeltz/scapegoat
3 participants
@mccartney @mwz @saeltz