Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PredefTraversableIsMutable doesn't apply to Scala 2.13 #294

Closed
mwz opened this issue Mar 7, 2020 · 2 comments · Fixed by #708
Closed

PredefTraversableIsMutable doesn't apply to Scala 2.13 #294

mwz opened this issue Mar 7, 2020 · 2 comments · Fixed by #708

Comments

@mwz
Copy link
Contributor

mwz commented Mar 7, 2020

Traversable aliases Iterable and it's also deprecated now in Scala 2.13, so it should probably be disabled when Scapegoat is run against a 2.13 codebase.
@mccartney
Copy link
Collaborator

Do we even have support to skip some inspections for some Scala versions?
I guess we need to add that.

@mccartney mccartney mentioned this issue Mar 8, 2020
Closed
@mccartney
Copy link
Collaborator

Answering myself, we do have support for enabling/disabling inspections per Scala major version, e.g.:
https://github.com/sksamuel/scapegoat/blob/5c690f685632d4b784fb0a187ef0091ec395a233/src/main/scala/com/sksamuel/scapegoat/inspections/collections/PredefSeqIsMutable.scala#L16

@saeltz saeltz mentioned this issue May 26, 2021
Merged
@saeltz saeltz mentioned this issue Nov 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PredefTraversableIsMutable & PredefIterableIsMutable don't apply on Scala 2.13 saeltz/scapegoat
2 participants
@mccartney @mwz