Support Scala 2.12.16 #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeltz
commented
Jul 4, 2022
| @@ -56,10 +56,10 @@ class ComparingUnrelatedTypesTest extends InspectionTest { | |||
| } | |||
| "for char" - { | |||
| "compared to char-sized long literal" in { | |||
| verifyNoWarnings("""object A { val c = 'a'; val c = l == 97L }""") | |||
| verifyNoWarnings("""object A { val c = 'a'; val l = c == 97L }""") | |||
There was a problem hiding this comment.
This test was throwing and error but not failing because it was no scapegoat warning.
| @@ -83,10 +83,6 @@ class PartialFunctionInsteadOfMatchTest extends InspectionTest { | |||
| future onComplete { | |||
| case _ => | |||
| } | |||
| future onSuccess { | |||
There was a problem hiding this comment.
This was throwing an error as well because onSuccess doesn't exist anymore in Scala 2.13.
|
👍🏼 |
|
@sksamuel, could you please release a new version? |
|
I can do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was released last month. I wanted to update a cross-built library but Scapegoat failed. This adds the relevant support.