Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala-compiler, scala-library, ... to 2.12.17 #678

Merged

Conversation

scala-steward
Copy link
Contributor

Updates

from 2.12.16 to 2.12.17.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (2.12.16).
You might want to review and update them manually.

.github/workflows/pr-checks.yml
README.md
Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scala-lang" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

@codecov-commenter
Copy link

Codecov Report

Base: 87.95% // Head: 87.95% // No change to project coverage 👍

Coverage data is based on head (c9f1d3e) compared to base (8a2e1a0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #678   +/-   ##
=======================================
  Coverage   87.95%   87.95%           
=======================================
  Files         141      141           
  Lines        1494     1494           
  Branches       33       33           
=======================================
  Hits         1314     1314           
  Misses        180      180           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

build.sbt Outdated Show resolved Hide resolved
@saeltz
Copy link
Collaborator

saeltz commented Oct 11, 2022

@mccartney, maybe you could click the "Update branch" button in the UI, accept my suggestion above and also get this merged for the next release? (I don't have write access to the repository.)

mccartney and others added 2 commits October 11, 2022 15:20
@mccartney mccartney merged commit 088d975 into scapegoat-scala:master Oct 11, 2022
@mccartney
Copy link
Collaborator

mccartney commented Oct 11, 2022

(I don't have write access to the repository.)

Granted. I hope @sksamuel doesn't mind.
Not that I feel the owner or anything, but I see your contributions as highly valuable here.

@sksamuel
Copy link
Collaborator

I don't mind :)

@saeltz
Copy link
Collaborator

saeltz commented Oct 11, 2022

Granted.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants