Add support for Scala 2.13.9 #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
saeltz
reviewed
Sep 28, 2022
henricook
force-pushed
the
scala-2139
branch
from
61aa78a to
f11a6e1
Compare
saeltz
approved these changes
Sep 28, 2022
|
@mccartney, would you do the merge and release please? |
mccartney
approved these changes
Sep 29, 2022
| scalaVersion := "2.13.8" | ||
| crossScalaVersions := Seq("2.11.12", "2.12.15", "2.12.16", "2.13.7", "2.13.8") | ||
| scalaVersion := "2.13.9" | ||
| crossScalaVersions := Seq("2.11.12", "2.12.15", "2.12.16", "2.13.7", "2.13.8", "2.13.9") |
There was a problem hiding this comment.
I think we have the tradition of keeping two minor versions per major version. Thus I suggest to remove 2.13.7.
There was a problem hiding this comment.
Ah. Now I can see @saeltz said we were hoarding 3 versions. That's fine. I must've remembered wrong.
There was a problem hiding this comment.
I wasn’t sure either. In the CI we had three, in SBT two. We can still clean it up afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #679
This is my first contribution to this project so please let me know if anything is missing
Requires a release after merge as it updates the README