Add support for scala 2.13.10 #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saeltz @mccartney If it's not too forward to tag you both - I'd appreciate a review when you get a moment, very similar to my 2.13.9 MR of last week |
mccartney
approved these changes
Oct 10, 2022
|
The failed check is scoverage failure which doesn't seem to have a version for 2.13.10 (?) or not sure what the problem with it is. |
Not sure what are you suggesting. Is it about not having a separate version of scapegoat per Scala minor version? |
Closed
|
Thanks for release! I'm not sure, do all our other dependencies just react very very fast (or automatically?). I'm not sure of the intricacies - I might have to look around to see how it's done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're thinking about removing our scapegoat dependency because in a scala version upgrade it's the only dependency (in our project with many dependencies) that doesn't seem to "just work". Do you think there's a better strategy that could be employed instead of manually naming versions like this?