Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the new Privacy API #15

Closed
scara opened this issue Mar 18, 2018 · 3 comments
Closed

Implement the new Privacy API #15

scara opened this issue Mar 18, 2018 · 3 comments
Assignees

Comments

@scara
Copy link
Owner

scara commented Mar 18, 2018

MDL-61307 and MDL-61397 landed into the main stream (3.3, 3.4 and 3.5) in the current weekly (20180315): it's time to implement what required by the new Moodle Privacy API.

We do not store any personal data so we must implement the metadata null provider, as already done e.g. in the core Global Search block.

@scara scara self-assigned this Mar 18, 2018
@scara
Copy link
Owner Author

scara commented Apr 9, 2018

The GDoc has been integrated in the Moodle Docs Wiki: new ref in https://docs.moodle.org/dev/Privacy_API#Plugins_which_do_not_store_personal_data .

scara added a commit that referenced this issue Apr 9, 2018
scara added a commit that referenced this issue Apr 9, 2018
scara added a commit that referenced this issue Apr 9, 2018
scara added a commit that referenced this issue Apr 9, 2018
scara added a commit that referenced this issue Apr 9, 2018
@scara
Copy link
Owner Author

scara commented Apr 9, 2018

Unfortunately I've tried many hacks to allow sharing the same plugin code on different branches AND PHP versions with no success: https://travis-ci.org/scara/moodle-local_twittercard/jobs/364187213.

The main issue is the fact that the Privacy API is different in 3.4 since it declares the return type in the null provider which is not supported in PHP 5.6, potentially used in 3.3: I'll introduce a separate branch to keep on supporting Moodle 3.3 (which is actually an effort).

scara added a commit that referenced this issue Apr 9, 2018
scara added a commit that referenced this issue Apr 9, 2018
scara added a commit that referenced this issue Apr 9, 2018
scara added a commit that referenced this issue Apr 9, 2018
scara added a commit that referenced this issue Apr 9, 2018
@scara
Copy link
Owner Author

scara commented Apr 10, 2018

A providential update to the Moodle Privacy API docs should get rid of all my past attempts to create a safer 3.3 only plugin branch: https://docs.moodle.org/dev/Privacy_API#Difference_between_Moodle_3.3_and_more_recent_versions .

TNX @abgreeve! 👍

@scara scara closed this as completed in 6e2d3ef Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant