-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove autotool builds #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andriish, I am totally in favour of dropping autotools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also agree: you're also properly testing CMake, and only the tested workflow should be left (the duplication is not useful).
@andriish just be aware that there are people packaging APFEL, e.g. and they might rely on autotools. Luckily, they are also clever enough to use a fixed tag (and I believe just a few people are using those packages). |
Hi @scarrazza , concerning the nixos --I'm sure they will be happy to use CMake. Just because if there are small problems in autotools one has to patch *a lot * of stuff, while for CMake it is just one file. |
I agree, autotools requires a lot more effort to be maintained, and it is less and less used as a build system. I was just raising the issue of downstream (another example is myself, but of course I can also fix it by myself). |
Remove
autotool
builds.The reasons:
autotools
are not good in general:autoreconf
autoreconf
and include the results in the tarballcmake
cmake
builds will be used -- means there will beAPFELConfig.cmake
installed and the integration ofapfel
with othercmake
projects will be as simple asconfigure
scripts.However that is up to you to decide and makes sense only if you are familiar with cmake at least a bit.