Added option to specify App Version #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
It seems, as I experienced today, that the x-pm-appversion header has a tendency to change rather often (with the versions… I guess). There are already three issues raised on the tracker related to this : #3, #7 and #11. Pull request #2 is an attempt at fixing this… but it's already broken before even being accepted since the app has bumped up in version since. Furthermore, #2 also changes the api version header x-pm-apiversion, but this does not seem necessary to actually get the email download to work (api version seems to be 3 right now, but even with x-pm-apiversion set to 1 download succeeds).
The approach used in the present pull request which is to make the appversion into a user supplied argument seems like a more robust one to me, since the program already asks users to copy-paste info from the headers anyway.
Let me know if there is anything looks wrong or needs fixing.
Regards,
Mark.