Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding submodule for Trigno Wireless and Tobii Pro Nano #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zentetsu
Copy link

Hi,

I have worked during the last few months on two sublibraries for EMG and Eye-Tracker and I would like to share my work.
I tested it on Windows, Linux and OSX.

Note: Currently, Eye-Tracker drivers are only provided for Windows and Mac.

@tstenner
Copy link
Collaborator

I haven't tested anything, but so far everything looks great.

Some thoughts:

  • I already wrote a TobiiPro connector that should handle the TobiiPro Nano. I don't have the device any more, so I'd gladly accept pull requests e.g. to add data (validity, 3D coordinates and so on to the stream) you need
  • Boost.Thread is a quite heavy dependency, especially since std::thread covers 99% of what it does and is supported by all recent compilers
  • the directory structure is a good idea, but for 8 source files it's somewhat easier to have everything in the root folder and avoids the #include "../include/..."
- if(WIN32)
	target_link_libraries(${PROJECT_NAME} PRIVATE
		libA
		libB
	)
endif()

can be shortened to

target_link_libraries(${PROJECT_NAME} PRIVATE
	libA
)
if(WIN32)
	target_link_libraries(${PROJECT_NAME} PRIVATE libForWindows)
endif()

Also, we'd need commit rights to the repositories so we can fix things. You could either transfer the repositories to the labstreaminglayer organization or add it to the repository. You'd keep the copyright and admin rights, of course.

@tstenner
Copy link
Collaborator

Also, see here for some conventions that make most boilerplate parts, e.g. config handling, easier

@Zentetsu
Copy link
Author

Thank you for your answer.
I will update the EMG sub-library to comply with your conventions.

Regarding the Eye-Tracker, I will not be able to test it because I'm leaving the lab where I used it.

@cboulay cboulay force-pushed the master branch 4 times, most recently from 3a47862 to 9ded670 Compare December 27, 2019 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants