Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests that (almost) always fail #218

Open
3 tasks
cboulay opened this issue May 25, 2024 · 2 comments
Open
3 tasks

Tests that (almost) always fail #218

cboulay opened this issue May 25, 2024 · 2 comments
Assignees

Comments

@cboulay
Copy link
Collaborator

cboulay commented May 25, 2024

  • MINGW - internal loguruthreadnames skip
  • MacOS - internal reuseport on ipv6 multicast - skip
  • pushpull benchmarks in MSVC win often segfault

The first 2 don't test LSL code directly so I have excluded the problematic config on the problematic target platform.

@cboulay
Copy link
Collaborator Author

cboulay commented May 25, 2024

I managed to reproduce a segmentation fault from the pushpull benchmark test locally. It happens here:

if (x < factory->storage_ || x >= factory->storage_ + factory->storage_size_)

It happens at the very end of the test case, as the outlet is going out of scope, triggering its cleanup:

lsl::stream_outlet::~stream_outlet() > lsl_destroy_outlet(...) > ~stream_outlet_impl() > lsl::factory::~factory()

During ~factory, this line

if (cur != sentinel()) delete cur;

cur is already nonsense.

image

@tstenner tstenner self-assigned this May 27, 2024
@cboulay
Copy link
Collaborator Author

cboulay commented Jun 6, 2024

#220 might be helpful: "bad_weak_ptr"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants